humanmade / block-editor-components Goto Github PK

A size prop for displaying the image would be nice, e.g.

<ImageControl
    value={ imageId }
    onChange={ ( image ) => setAttributes( { imageId: image?.id } ) }
    size="thumbnail"
/>

Hi HM family!

We were using the PostPicker component recently and we had some manually re-ordering to do. The reOrderUp/Down features work really well ❤ - but I'd love to be able to drag and drop items to control the ordering.

Absolutely all good, if this isn't on the roadmap - if we need it quicker, we'll patch upstream for y'all - but it's a low priority enhancement for us.

All the best y'all 👋 🙇 💯 🎉

New package versions should get pushed to NPM automatically when releases are created.

@mattheu shared a doc on how this might be done here:

https://mskelton.medium.com/automated-npm-publishing-using-github-actions-594ef1aaabe2

If an invalid numeric value such as 0 is passed as the value prop, then ImageControl will print it.

Tested on WP 5.9

It would be nice to have a version of the ImageControl that's specifically for selecting video type media

Currently the alt attribute in an <ImageControl > is alt="" but it should use a description or caption if the attachment provides one

I'd suggest we do a release of v0.4 soon, what blockers do we have?

cc @mattheu @Sephsekla

When you pick an image, imageUrl may not have a value. This could be due to an error or because it hasn't loaded in yet, but during this period the only indication it worked is the button changes its text.

Instead this && check should be a ternary or another check that displays the WP loading spinner to give user feedback:

							{ imageUrl && (
								<Button isLink onClick={ open }>
									<img alt="" src={ imageUrl } />
								</Button>
							) }