Git Product home page Git Product logo

Comments (2)

elliottmangham avatar elliottmangham commented on June 6, 2024 1

@danhumaan thank you! And that's perfectly understandable, actually it's what I love about Modaal (how clean it is) so it makes sense. I'll have a look at the links you provided and see what I can do.

from modaal.

danhumaan avatar danhumaan commented on June 6, 2024

Hey @elliottmangham thanks for the kind words. Currently there is no support to detect video end, and allow for an event to fire, or other video events.

Our goal is to keep Modaal as lean as possible while ticking all the right boxes of accessibility, aesthetics and features other designers and developers might want. Extending the plugin to support video events would introduce other dependencies and weight that not all users may want, such as the need for the Vimeo Froogaloop library.

See this stack overflow thread, and this Vimeo developer page for information and examples on how you may be able to connect to your video to a 'finish' event. You could then, using that event, call the $('.modaal-selector').modaal('close'); method to trigger the modal close.

Youtube appears to be slightly more friendly however I don't believe it would be wise at this time to add these event checks for one supported video format and not the other in the plugin's current setup, without overcomplicating things.

We may look into this again sometime down the track if we ever extend the video functionality for more control.

from modaal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.