Comments (2)
hi @peterh-capella thanks for raising the issue. This version of Modaal is no longer being worked, with a new non-jquery dependant version being planned.
Rather than you invest time in applying it to this version, if you're able to share the steps you've used to identify and test the issue, we can apply that approach to the new version when it's further along
from modaal.
The issue came up for me due to my firm's use of the Siteimprove service (https://siteimprove.com/). Their recent updates to their testing engine flagged many instances of a best-practice issue, "Text not included in an ARIA landmark." This would show up for applications that included an introductory modal describing the academic activity the user was starting. We have standard pattern of opening that modal on page load which then injects the HTML structure at the end of the <body>
. This removes the content from the <main>
landmark, leaving it outside of any landmark and thus failing the test. You can see this on the Modaal demo page by opening one of the examples and the using their Chrome extension.
My plan to remediate this was to look into where the script built the div.modaal-wrapper
and associated HTML structure and prior to that see if the content defined either by the trigger's href
or content_source
existed inside one of the elements with implicit ARIA landmark roles (<header>
, <footer>
, <main>
, <nav>
, <aside>
, <form>
or <section>
). Then build the existing HTML structure inside that element. Complications I see arising from this are the styling of the modal position based on the parent.
Another option would be to use a <section>
as the outer wrapper of the modal structure. That would require giving the region an accessible name, most likely through an aria-label
attribute, which presents complications of naming and localization.
I hope that's useful. If I can assist with the new version let me know.
from modaal.
Related Issues (20)
- Change of source image within content-source conflict HOT 2
- Focus management (focus trap) HOT 1
- Option to loop through the gallery
- How To: Inserting modal content further up the page HOT 3
- Back tab focus not working
- Opening a image gallery from multiple sources
- How to open modal not user button? HOT 5
- How to close the modal?? HOT 1
- Question: is it possible to somehow autoplay the gallery images, so that no user interactive is needed?
- Close button first focusable element.
- Multiple instances of modaal issue HOT 3
- Getting clicked element's attributes HOT 9
- Modaal window background color
- should_open option doesn't work as data attribute
- Support ES6 loading
- How can I make this work with keyboard shortcuts.
- Animation options
- How to close in iframe/ajax?
- MP4 video not start in Mac Safari
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from modaal.