Git Product home page Git Product logo

Comments (8)

hughsie avatar hughsie commented on July 22, 2024

Have you got an example please? I assume it's duplicate with the same ID you mean. In general AsStore just merges duplicate data, although does check (quite rightly) for duplicate screenshots and releases.

from appstream-glib.

DimStar77 avatar DimStar77 commented on July 22, 2024

http://download.opensuse.org/repositories/GNOME:/Apps/openSUSE_Factory/repodata/?P=*appdata.xml.gz

from appstream-glib.

hughsie avatar hughsie commented on July 22, 2024

The thing is, duplicated IDs in an AppStream file is something that really should fail validation. libappstream-glib happens to accept it and kinda do the right thing, but other libraries exist that parse the files too.

from appstream-glib.

DimStar77 avatar DimStar77 commented on July 22, 2024

Thibg is, it does not complain about the IDs, but about the screenshot... Quite an arbitrary attribute of a component.

Sent from my Sony Xperia™ smartphone

---- Richard Hughes wrote ----

The thing is, duplicated IDs in an AppStream file is something that really should fail validation. libappstream-glib happens to accept it and kinda do the right thing, but other libraries exist that parse the files too.


Reply to this email directly or view it on GitHub.

from appstream-glib.

hughsie avatar hughsie commented on July 22, 2024

I think this is better now, right?

from appstream-glib.

DimStar77 avatar DimStar77 commented on July 22, 2024

Duplicate screenshots are still conidered failure in validate-relax (tested with 0.5.1)

from appstream-glib.

DimStar77 avatar DimStar77 commented on July 22, 2024

1fe19d97dc4737134adf38d67a08fb490aa50c91d97344d75d9ac9ed9daf9690-appdata.xml.gz: FAILED:
• duplicate-data : nm-connection-editor.desktop: <screenshot> has duplicated data
• duplicate-data : org.gnome.Dictionary.desktop: <screenshot>> has duplicated data
• duplicate-data : gpk-application.desktop: <screenshot>> has duplicated data
• duplicate-data : gpk-update-viewer.desktop: <screenshot> has duplicated data

from appstream-glib.

hughsie avatar hughsie commented on July 22, 2024

I think that's the right behaviour for a validator, sorry.

from appstream-glib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.