Git Product home page Git Product logo

Comments (5)

heftig avatar heftig commented on July 30, 2024

Looking at the test that f939f14 added, I think even if it did pass, the code is broken.

The source markup is:

appstream-glib/libappstream-glib/as-self-test.c

Lines 2868 to 2872 in 2415ed7

const gchar *valid_em_code = "<description>"
"<p>"
"It now also supports <em>em</em> and <code>code</code> tags."
"</p>"
"</description>";

And the expected data is:

appstream-glib/libappstream-glib/as-self-test.c

Line 2944 in 2415ed7

g_assert_cmpstr (as_node_get_data (n2), ==, "It now also supports<em>em</em> and <code>code</code> tags.");

The space between supports and <em>em</em> is gone.

from appstream-glib.

hughsie avatar hughsie commented on July 30, 2024

It worked here (and continues to work); can you debug a bit please?

from appstream-glib.

heftig avatar heftig commented on July 30, 2024

Any idea what could affect this? Some dependency?

from appstream-glib.

heftig avatar heftig commented on July 30, 2024

The new fields in the AsNodeToXmlHelper struct aren't being initialized.

(Also, they should probably be bitfields for consistency.)

from appstream-glib.

hughsie avatar hughsie commented on July 30, 2024

Can you do a pr please?

from appstream-glib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.