html-next / ember-hammertime Goto Github PK

The devDependency eslint-plugin-ember was updated from 5.2.0 to 5.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-ember is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

The devDependency ember-resolver was updated from 5.2.1 to 5.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-resolver is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The ast walker is adding the touch-action styles multiple times to each dom element withing a loop as described in this example:

//JS file
import Component from '@ember/component';
export default Component.extend({
	actions: {
		jumpTo() {
			//
		}
	},

	init() {
		this._super(...arguments);
		this.set('data', [1,2,3]);
	}
});

// HBS file
{{#each data as |item|}}
	<div class="jumpable-{{item}}" onclick={{action 'jumpTo'}}>Hammer Time {{item}}</div>
{{/each}}

// DOM result 

<div style="touch-action: manipulation; -ms-touch-action: manipulation; cursor: pointer;touch-action: manipulation; -ms-touch-action: manipulation; cursor: pointer;" class="jumpable-1">Hammer Time 1</div>
<div style="touch-action: manipulation; -ms-touch-action: manipulation; cursor: pointer;touch-action: manipulation; -ms-touch-action: manipulation; cursor: pointer;" class="jumpable-2">Hammer Time 2</div>
<div style="touch-action: manipulation; -ms-touch-action: manipulation; cursor: pointer;touch-action: manipulation; -ms-touch-action: manipulation; cursor: pointer;" class="jumpable-3">Hammer Time 3</div>

The solution could be as simple as a check in the walker if the node has already a touch action properties, if I'm not missing something:

TouchActionSupport.prototype.transform = function TouchActionSupport_transform(ast) {
  var pluginContext = this;
  var walker = new pluginContext.syntax.Walker();

  walker.visit(ast, function(node) {
    if (pluginContext.validate(node)) {
      var style = elementAttribute(node, 'style');
      if (!style) {
        style = {
          type: 'AttrNode',
          name: 'style',
          value: { type: 'TextNode', chars: '' }
        };
        node.attributes.push(style);
      }
      // insert the touch action properties only if not present
      if(style.value.chars.indexOf(touchActionProperties)===-1) {
	      style.value.chars += touchActionProperties;
      }
    }
  });

  return ast;
};

I can open an PR with a test if that can help!

Thanks

We are using Ember Bootstrap project forms (http://kaliber5.github.io/ember-bootstrap/api/classes/Components.FormElement.html)
It defines action as a handler for submit.
When combined with hammertime a whole form gets cursor: pointer

Is there a way to disable the {{action}} matching in hammertime?

I've just migrated my application to ember.js 2.8 and it started throwing error in the console.

Uncaught Error: Assertion Failed: You cannot use attributeBindings on a tag-less component: <yyyyyy@component:xxxxx::ember382>

Due to this error, the app doesn't load and shows an empty page.

I've created a small demo app with just ember-hammertime and a tagless component and it still throws the same error: https://github.com/thagul/hammertime-2-8
To verify just run the app and check the console.

The devDependency ember-try was updated from 1.2.1 to 1.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-try is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency ember-cli-template-lint was updated from 1.0.0-beta.3 to 1.0.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-cli-template-lint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

If I add this addon to a new 2.15-beta.1 app, I'm getting build errors like these:

The Broccoli Plugin: [BroccoliMergeTrees: TreeMerger (preprocessedApp & templates)] failed with:
TypeError: Cannot read property 'visitors' of undefined
    at preprocess (P:\Projects\reproduction-build1\node_modules\ember-source\dist\ember-template-compiler.js:3921:47)
    at exports.precompile (P:\Projects\reproduction-build1\node_modules\ember-source\dist\ember-template-compiler.js:1551:42)
    at Object.exports.default (P:\Projects\reproduction-build1\node_modules\ember-source\dist\ember-template-compiler.js:16409:12)
    at Object.template (P:\Projects\reproduction-build1\node_modules\ember-cli-htmlbars\utils.js:29:40)
    at TemplateCompiler.processString (P:\Projects\reproduction-build1\node_modules\ember-cli-htmlbars\index.js:76:40)
    at Promise.then.result.output (P:\Projects\reproduction-build1\node_modules\broccoli-persistent-filter\lib\strategies\persistent.js:41:23)
    at initializePromise (P:\Projects\reproduction-build1\node_modules\rsvp\dist\rsvp.js:567:5)
    at new Promise (P:\Projects\reproduction-build1\node_modules\rsvp\dist\rsvp.js:1039:33)
    at P:\Projects\reproduction-build1\node_modules\broccoli-persistent-filter\lib\strategies\persistent.js:40:18
    at tryCatch (P:\Projects\reproduction-build1\node_modules\rsvp\dist\rsvp.js:525:12)

The broccoli plugin was instantiated at:
    at BroccoliMergeTrees.Plugin (P:\Projects\reproduction-build1\node_modules\broccoli-plugin\index.js:7:31)
    at new BroccoliMergeTrees (P:\Projects\reproduction-build1\node_modules\ember-cli\node_modules\broccoli-merge-trees\index.js:16:10)
    at Function.BroccoliMergeTrees [as _upstreamMergeTrees] (P:\Projects\reproduction-build1\node_modules\ember-cli\node_modules\broccoli-merge-trees\index.js:10:53)
    at mergeTrees (P:\Projects\reproduction-build1\node_modules\ember-cli\lib\broccoli\merge-trees.js:85:33)
    at EmberApp._mergeTrees (P:\Projects\reproduction-build1\node_modules\ember-cli\lib\broccoli\ember-app.js:1840:12)
    at EmberApp.appAndDependencies (P:\Projects\reproduction-build1\node_modules\ember-cli\lib\broccoli\ember-app.js:1130:51)
    at EmberApp.javascript (P:\Projects\reproduction-build1\node_modules\ember-cli\lib\broccoli\ember-app.js:1253:30)
    at EmberApp.toArray (P:\Projects\reproduction-build1\node_modules\ember-cli\lib\broccoli\ember-app.js:1697:12)
    at EmberApp.toTree (P:\Projects\reproduction-build1\node_modules\ember-cli\lib\broccoli\ember-app.js:1719:38)
    at module.exports (P:\Projects\reproduction-build1\ember-cli-build.js:28:14)

Output from ember version --verbose && npm --version && yarn --version:

ember-cli: 2.15.0-beta.1
http_parser: 2.7.0
node: 6.11.0
v8: 5.1.281.102
uv: 1.11.0
zlib: 1.2.11
ares: 1.10.1-DEV
icu: 58.2
modules: 48
openssl: 1.0.2k
os: win32 x64
npm: 4.6.1
yarn: 0.27.5

ember-cli-babel: 6.6.0
ember-cli-htmlbars: 2.0.2

As already reported to the ember repo here, when ember > 3.11 is used with this addon, code like

<span class="trigger" {{action (toggle '_expanded' this)}}>

will trigger the following warning:

WARNING: Binding style attributes may introduce cross-site scripting vulnerabilities; please ensure that values being bound are properly escaped. For more information, including how to disable this warning, see https://emberjs.com/deprecations/v1.x/#toc_binding-style-attributes. Style affected: "touch-action: manipulation; -ms-touch-action: manipulation; cursor: pointer;"

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Trying to install (currently on Ember 1.13.8) and keep getting and unexpected token error:
Unexpected token ,
.../node_modules/ember-hammertime/htmlbars-plugins/touch-action.js:122
TouchActionSupport,

The devDependency ember-export-application-global was updated from 2.0.0 to 2.0.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-export-application-global is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

With ember-hammertime installed:

Template Compiler Error (TemplateCompiler) in lords-fielder-tool/application/template.hbs

Cannot read property 'start' of undefined

Can the AST walker handle <div onclick={{action cases?

I admit I know nothing about the subject, but do we still need to be using this or is support for removing click delays on taps just built in these days? This SO post seems to indicate it's all built in https://stackoverflow.com/questions/42250283/is-fastclick-js-still-needed as does this ftlabs/fastclick#514 @runspired @eriktrom

If I have this library, can I skip FastClick? Or do I need that anyway? I'm building Ember apps for mobile.

Following up from hammerjs/hammer-time#28:

Since the polyfill doesn't work on selects on mobile, perhaps the AST walker should not apply touch-action to select tags? Alternatively, are you open to some kind of config to whitelist the elements instead of hard-coding isFocusable?

Hi,

I've tried running my app agains the latest version of ember-hammertime#develop and I've observed that the attributeBindings are being ignored on my component which specifies a tag name of 'img'. In addition, my checkboxes are rendering as input boxes.

I suspect it might be due to this: But thats just speculation

It includes babel 5.x in its dependencies. Fixing this should allow using it again here and in ember-gestures

wild guess atm

The devDependency ember-try was updated from 1.0.0 to 1.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-try is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Same issue as #6. Hammertime not working with iOS 9.3, tested with 4 devices. Works perfectly on 9.2

• Fastlick not installed
• ember-hammertime 1.0.0
• Ember 2.6.2
• Meta tags set touser-scalable=no, initial-scale=1, maximum-scale=1, minimum-scale=1, width=device-width
• touch-action: manipulation being applied
• Added [data-ember-action], a, button, input, .link { cursor: pointer; } to stylesheet
• Cordova 6.2.0

The devDependency ember-cli-inject-live-reload was updated from 1.10.0 to 1.10.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-cli-inject-live-reload is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

See https://github.com/martndemus/ember-font-awesome/pull/96 for example

I'm getting the following errors in my ember-cli output

DEPRECATION: ember-cli-htmlbars-inline-precompile is opting out of caching due to an AST plugin that does not provide a caching strategy: `touch-action`.

DEPRECATION: ember-cli-htmlbars is opting out of caching due to an AST plugin that does not provide a caching strategy: `touch-action`.

I chatted to @runspired and this has actually been fixed in develop branch. I can confirm that if I run against the develop branch then the warning dissapears. Just leaving this here to help anyone that might encounter this until a new version is released

In the touch-action.js Mixin, there is a reference to Ember.String.isHTMLSafe, which is not a valid Ember resource. This is causing the code to break when otherStyle is valid.