hpinc / oneflow-sdk-php Goto Github PK

Reference to $this->printTypes is written as $this->$printTypes by mistake.

While creating an order, I'm trying to add to each "component" our own unique identifier.

For "order" and "item" the fields are called

• sourceOrderId
• sourceItemId

In the documentation
https://docs.oneflowcloud.com/products/siteflow-order-structure/
it states as well that the field for a component is called

• sourceComponentId

But I'm not able to find a corresponding method setSourceComponentId. I only find setComponentId and this will only set componentId in order.josn. I'm not sure if this will work as this is not even documented anywhere. Could you please check this and add the correct method setSourceComponentId?

If you need further details, please don't hesitate to ask.

We just got the new code from version 1.2.0 via composer update.

Our first tries failed with the following error

Trying to get property 'retries' of non-object
This blocked us from using this library as we are currently not able to send new orders to siteflow.

We identified the error in OneflowSDK.php in line 59 and following
$this->retries = $options->retries ?: 3;
You must not try to directly access objects' attributes or methods if they can be null!

A simple fix for this would be
$this->retries = isset($options->retries) ? $options->retries : 3;

Keep in mind that you have the same issue in the next lines again for other attributes of the object.

Please let me know, as soon as you're done with the fix.

PHP 8 requires the optional parameters to come after the required ones in method signatures.

Deprecated: Required parameter ($town | $postcode | $isoCountry) follows optional parameter $address2 in ...\vendor\oneflow\php-sdk\src\order\orderData\shipment\shipment.php on line 97

Deprecated: Required parameter ($town | $postcode | $isoCountry) follows optional parameter $address2 in ...\vendor\oneflow\php-sdk\src\order\orderData\shipment\shipment.php on line 129

The deprecation notice is triggered at the compile time and it will be raised even if the method is not called.