hotwax / import Goto Github PK

Current behavior

When deselecting a single product from a group of products, all the products in that group gets deselected

Expected behavior

Deselecting a single product from the parents group should only deselect that product and virtual product.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

Clicking on view logs opens the link in the same tab which means the user loses their import app.

Expected behavior

Open the logs link in a new tab.

Steps to navigate to perform review action

1. Login into application
   OMS: dev-apps
   Username: aaron.wagner
   password: Aaron@123
2. Click on Review button without uploading the file and selecting the fields

Currently, user is navigated to Purchase Order details page

Review button should be disabled till file is not uploaded and all fields are not selected

What is the motivation for adding/enhancing this feature?

Missing Products Modal helps users to correct missing/wrong product SKU codes. User can select one SKU code at a time, the selected SKU code would appear in the input box letting user edit or rewrite the SKU code. Once done, user can update the SKU code. Once the user press the Update button, API will take the input and also fetch the product SKU code from the product information database. Following, there will be two results scenarios:

1. If SKU codes match, input is valid and product will move to the completed tab.
2. If SKU codes do not match, input is invalid and user must put the different SKU code. Note: User can abandon correcting the one SKU code and might move to other incorrect SKU code.

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

What is the motivation for adding/enhancing this feature?

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

What is the motivation for adding/enhancing this feature?

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

Current behavior

Select deselect not working on PO detail page and missing skus not displaying in completed section on updating

Expected behavior

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Steps to reproduce:

• Logout from the app
• Verify that the console having an error: [vuex] unknown action type: user/clearOrderList

Compiled with 5 warnings

Module Warning (from ./node_modules/eslint-loader/index.js):
 
 /Users/shantanubangar/Desktop/Hotwax Commerce/import/src/components/Image.vue
   42:33  warning  'error' is defined but never used  @typescript-eslint/no-unused-vars


Module Warning (from ./node_modules/eslint-loader/index.js):

 /Users/shantanubangar/Desktop/Hotwax Commerce/import/src/store/modules/order/actions.ts
   6:8  warning  'router' is defined but never used  @typescript-eslint/no-unused-vars


Module Warning (from ./node_modules/eslint-loader/index.js):
 
/Users/shantanubangar/Desktop/Hotwax Commerce/import/src/store/modules/user/actions.ts
   88:25  warning  'state' is defined but never used  @typescript-eslint/no-unused-vars


Module Warning (from ./node_modules/eslint-loader/index.js):
 
 /Users/shantanubangar/Desktop/Hotwax Commerce/import/src/views/OrderDetail.vue
   276:23  warning  'response' is assigned a value but never used  @typescript-eslint/no-unused-vars


Module Warning (from ./node_modules/eslint-loader/index.js):

 /Users/shantanubangar/Desktop/Hotwax Commerce/import/src/views/PurchaseOrder.vue
   65:107  warning  'IonNote' is defined but never used  @typescript-eslint/no-unused-vars

Steps to navigate to Purchase Order Details page

1. Login into application
   OMS: dev-apps
   Username: aaron.wagner
   password: Aaron@123

2. Upload the below CSV:
   DM12234_SUMPO111111.csv

3. Select appropriate fields and click on Review
   

4. Open action menu for individual records, actions should cursor as pointer

Current behavior

If order buffer is greater than or equal to the quantity of any item, then we display a toast the states the quantity of items is set to 1.
and also a default toast that says changes have been applied successfully.

One toast overlaps over the another.

Expected behavior

Steps to reproduce the issue

1. log into the application.
2. Upload a CSV
3. Click on bulk adjustment
4. Set the value or order buffer greater then the quantity of any item.
5. Click on save

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

When applying any mapping, the selected mapping name should not be set to Create new mapping input field.

This could be confusing if we are allowed to update the currently selected mapping.

Expected behavior

It should only reflect in drop down.

Steps to reproduce the issue

1. Upload any file
2. Select any mapping from dropdown

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

If the user switches to another page, like the settings page, while reviewing their PO, when they return to the upload screen they land on the file upload screen which is disorienting.

Expected behavior

There should be a pop up that warns the user that if they switch to another screen while reviewing their PO, that their changes will be lost and they'll have to restart.

Current behavior

When we upload a file for the second time & click on upload button to upload a new file, instead of uploading a file if we click on cancel button, it gives errors.

Expected behavior

On clicking "Cancel" button second time, it should give any error

Steps to reproduce the issue

1. Click on Upload button on "Purchase Order" page.
2. Upload a file.
3. Click on Upload button again & this time instead of uploading a file. Click on "Cancel" button.
4. Check console for errors.

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

If the CSV that was uploaded has one facility ID, the drop down should pre-populate with the uploaded facility.

If the uploaded CSV has multiple facilities then the selector should show "Multiple"

What is the motivation for adding/enhancing this feature?

After uploading a file it's not immediately obvious if the file uploaded and what the name of the file was.

What are the acceptance criteria?

The file name should be closer to the upload button so the user can see it if they're about to re-upload a file. It should also be bold so it stands out on the page.

Can you complete this feature request by yourself?

• YES
• NO

Current behavior

When clicking on revert on a style, the ordered qty is not reverted to what was uploaded. Rather it seems like its changed to what the first item has.

Expected behavior

It should change back to what was initially uploaded

Steps to reproduce the issue

Upload PO, adjust qty with buffer and click reset.

Can you handle fixing this bug by yourself?

• YES
• [x ] NO

Current behavior

Currently, when creating a new mapping we are generating a random id for passing the same in the request, as the in parameter in the service is required.
But in current scenario as well, we are using the id returned from the api (which is an auto generated id) and we are using the same to identify the mappings.

Expected behavior

Need to remove the code for generating the id, once the id param will become optional

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

When changing the current uploaded file, the mappings selected remains as is and then clicking review button will break the app flow, as the mappings were selected as per the previous file and current file might not have those colunms.

Expected behavior

When changing the file, all the values should reset to default.

Steps to reproduce the issue

1. Upload a file
2. Select a mapping
3. Change the uploaded file
4. See that the select mapping remains as is, but all the values should reset to default

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

With node 16, the build fails due to eslint version mismatch in dependencies

This is fixed in Job Manager:
hotwax/job-manager#327

Current behavior

When we apply order buffer, in case any of the item has quantity less than order buffer, the quantity becomes negative after applying changes.

Expected behavior

Possible fixes:

1. Apply buffer on items whose quantity is greater than the order buffer value and display a toast that says couldn't apply order buffer on some of the items and deselect those items and display their skus in either toast or modal.

2. Apply buffer on items whose quantity is greater than the order buffer value and display the rest of the items in red color

3. Find out the minimum quantity of items in the csv and set it as the maximum value of order buffer.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

What is the motivation for adding/enhancing this feature?

• Improve logic for updating missing facilities.
• Implement static UI for missing Skus modal(#122 (comment))
• Make missing sku modal functional

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

Current behavior

In case the user is on PO detail page and token expires, instead of directly navigating the user to login page it displays an alert.

Expected behavior

If the token is expired, the user should be redirected to login page without any alert.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

1. When uploading a file we are storing the file content's in a variable which is an array of object, and when accessing that variable we are always accessing 0th index of it to use the file's content which will be difficult to handle. So when storing the file content in the variable we can save the 0th index so everytime when accessing it, we don't need to explicitly define the index.

2. In areAllFieldsSelected method we are using every method to check for un-selected values when mapping, but we can simply use some method and revert its logic.

Expected behavior

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

When uploading a purchase order, an alert is displayed.

Expected behavior

The alert should not be displayed when uploading purchase order, it should navigate directly to PO page.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• [ x] YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

If we don not upload a file and enter some mapping name & save it, it saves in the mapping list, which is not useful.

Expected behavior

SAVE MAPPING button should save mapping only if

1. File is uploaded
2. All field mappings are mapped
3. A mapping name is entered

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

What is the motivation for adding/enhancing this feature?

Currently, we store field mappings in localstorage, use APIs to store it at backend.

APIs:

createDataManagerMapping
Parameters:
mappingPrefId (optional)
mappingPrefValue
mappingPrefTypeEnumId
fromDate
thruDate

updateDataManagerMapping
Parameters:
mappingPrefId (optional)
mappingPrefValue
mappingPrefTypeEnumId
fromDate
thruDate

deleteDataManagerMapping
Parameters:
mappingPrefId

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

Once uploaded the inventory count will be set to the values in CSV.

Here is the format for CSV

facilityId | externalFacilityId | productId | idType | idValue | availableQty | locationSeqId | comments

What is the motivation for adding/enhancing this feature?

What are the acceptance criteria?

• Order Buffer should accept percentage value

Can you complete this feature request by yourself?

• YES
• NO

Additional information

What is the motivation for adding/enhancing this feature?

Currently the import app can only accept POs with single PoId.
Add support for multiple POs

Sample csv :
DM12234_SUMPO111111 (1).csv

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

Current behavior

Some of the static text is not added in translation file, thus giving warnings related to translation not found.

Expected behavior

There should not be any warning on console for static text

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Some of the missing text are:

• View
• Upload purchase order
• Make sure all the data you have entered is correct and only pre-order or backorder items are selected
• cancel

Also check for any other missing text.

What is the motivation for adding/enhancing this feature?

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

Current behavior

There is no way to verify whether the mapping has been saved or not. When the user clicks on the save button multiple times multiple mapppings with same name are created and stored.

Expected behavior

When the user clicks on save button, after the save action mapping name input should be set empty as this will disable the save mapping button, it will restrict the user from saving the same mapping multiple time.

Steps to reproduce the issue

1. Log into the application.
2. Upload CSV
3. Map fields
4. Enter mapping name
5. Click on save mapping multiple time
6. Click on field mapping drop down

It will display multiple mappings with the same name.

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

What is the motivation for adding/enhancing this feature?

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

Reference: https://github.com/hotwax/job-manager/tree/main/.github

Current behavior

There is a Search.vue file that is not used anymore, and thus increasing the build size of the app.

Expected behavior

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

As described at https://app.clickup.com/t/2h1ax9r :

While uploading a purchase order through Import App, the apply button is repeating the functionality.

For example: I tried uploading a purchase order with 20 quantity and added a buffer of 2 and clicked on "Apply", the quantity was reduced to 18. Then, I clicked on "Apply" again and the quantity reduced to 16 without any changes made in the conditions.
Same thing happened with buffer days.

Expected working of the button: if clicked on apply for the second time, it should not apply the conditions again.

Expected behavior

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

When clicking on reset action for an item and if the item is not selected then it automatically gets selected

Expected behavior

On reset action the item should not get selected.

Steps to reproduce the issue

1. Upload a file and map all the fields and move to details page
2. Click on more actions for an item that is not selected
3. Click reset and verify that the item gets selected.

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

What is the motivation for adding/enhancing this feature?

When user uploads a CSV with an invalid date time format we need a streamlined way of helping them correct their data.

What are the acceptance criteria?

Clicking on the chip with an invalid date time should open a modal where the user can configure the format they want to use and see why their input is invalid.

Additional information

What is the motivation for adding/enhancing this feature?

Missing Products Modal helps users to correct missing/wrong product SKU codes. User can select one SKU code at a time, the selected SKU code would appear in the input box letting user edit or rewrite the SKU code. Once done, user can update the SKU code. Once the user press the Update button, API will take the input and also fetch the product SKU code from the product information database. Following, there will be two results scenarios:

1. If SKU codes match, input is valid and product will move to the completed tab.
2. If SKU codes do not match, input is invalid and user must put the different SKU code. Note: User can abandon correcting the one SKU code and might move to other incorrect SKU code.

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

Current behavior

Purchase order data is not cleared on logout.

Expected behavior

Steps to reproduce the issue

1. Login to the application.
2. Upload PO CSV
3. Map the fields.
4. Click on review button.
5. Navigate to settings page and logout.
6. Login again and you find the previous PO Uploaded and fields mapped.

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

Warning:
Not found 'Map all fields' key in 'en' locale messages.
https://github.com/hotwax/import/pull/114/files#diff-67b6dfeb3964c5aec1aeca52a3ea39e33be0901f88fa7fad8990bb7763b31fdbR145

Check for all other instances and fix them

Expected behavior

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

What is the motivation for adding/enhancing this feature?

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

Current behavior

When clickin Go to oms or any other external link then those links open in the same tab. Also when changing the date format the sample does not update.

Expected behavior

• All external links should be open in new tab
• Sample date format should be updated on clicking save button

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

If we have some saved mapping, and file is not uploaded, we can still select a mapping which does not have any effect.

Expected behavior

User should not be able to select a mapping before uploading a file.

Steps to reproduce the issue

• Login into the app
• Select a mapping from available mappings before uploading a file and verify

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

When logout/login then having errors in console related to reading undefined/null.

Expected behavior

There should not be any error in any case.

Steps to reproduce the issue

1. Open app and login, and see the errors in console
2. Logout from the app and see the errors in console

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information