Git Product home page Git Product logo

form-handler-component's Introduction

form-handler-component's People

Contributors

eddypouw avatar gwendolenlynch avatar janlam7 avatar jaspers2307 avatar linaori avatar mvannes avatar nicoschoenmaker avatar nutama avatar ping-localhost avatar sstok avatar svandervlugt avatar yannickl88 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

form-handler-component's Issues

Handlers stop sharing instances by using `shared: false`

The handlers are stateful, that's because it contains setters and the data object is integrated inside. There's no real way to prevent this without losing information about types. While the form handlers are services, you never use them like this as they get passed along with the action arguments.

Due to their stateful nature, I'd like to have the collector compiler pass add the shared option as false to all handlers during container compilation. It might be a slight behavioural change, but I consider this a bug because it gives unexpected results if the handlers are shared.

Would there be any implications when adding this option?

[RFC] Consider some renamings

This issue ask for quite a big change, but I just wanted to share my thoughts about this cool package. It's quite hard to grasp at first and I think naming is part of this.

The name that confused me most is the FormProviderInterface. It doesn't actually provide anything, you pass the handler (and optionally the form) to it. In fact, this is the actual form handler.

On the other hand, FormHandlerInterface isn't about handling at all (it's delegated to both FormProviderInterface and FormSuccesHandlerInterface/FormFailureHandlerInterface). In fact, this interface is more about providing the form. It's more like a form manager or the like.

I think renaming these, especially the FormProviderInterface could help in understanding the responsibilities of the classes.

Please note that I'm just starting with this bundle. Maybe the names do make lots of sense and I just don't understand the internals good enough yet.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.