horusiath / akkacqrs Goto Github PK

In the line 74 of AggregateCoordinator, there is a check for the terminated message. I can presume why there is a check, because the actor has to be removed from the list.

But I don't know why there is a check for pending commands from line 81 that done inside the block. Shouldn't the actor be recreated anytime there is a command for an actor and if it does not exist? In that case, shouldn't the code be from 81 to 91 outside of the if block as shown below?

     protected override bool Receive(object message) 
     { 
         var terminated = message as Terminated; 
         if (terminated != null) 
         { 
             // if Terminated message was received, remove terminated actor from terminating children list 
             _terminatingChildren.ExceptWith(new[] { terminated.ActorRef }); 
          }
         else 
         {
             // if there were pending commands waiting to be sent to terminated actor, recreate it 
             var groups = _pendingCommands.GroupBy(cmd => cmd.PersistenceId == terminated.ActorRef.Path.Name).ToArray(); 
             _pendingCommands = groups.First(x => !x.Key).ToList(); 
             var commands = groups.First(x => x.Key); 
             foreach (var pendingCommand in commands) 
             { 
                 var child = Recreate(pendingCommand.AggregateId, pendingCommand.PersistenceId); 
                 child.Tell(pendingCommand.Command, pendingCommand.Sender); 
             } 

             return true; 
         } 

         return false; 
     } 

I think the method PatchWithdrawal should return an object which should contain the account and balance. Or another GET method to return an account which shows the balance.

Code snippet: public async Task PatchWithdrawal(Withdraw request)

Do you have any thoughts on where to incorporate this?

Hi,

I don't see the projection (building the read model) part of CQRS in the example. Do I missed some lines or is this not included?

I think this should propagate the event to some kind of EventBus in the AggregateRoot here
https://github.com/Horusiath/AkkaCQRS/blob/master/CSharp/Akkme.Shared/Infrastructure/Domain/AggregateRoot.cs#L37

Could it be that, there is a missing line before this code?

Context.System.EventStream.Subscribe(Self, typeof (UserEvents.UserRegistered));

In the extension.cs, a router has been used for userindex actor. Is there a reason why the other coordinators like account and user have not been used in a router but as an actor only?

First of all, I want to say that this is an awesome example that I have seen in the area of CQRS with AKKA.NET.

In lines 64 to 67 in the ReceiveRecover method, I see that ReceiveRecover can get an event other than the SnapshotOffer and it will update the state. I don't see a case that can happen other than it receives an event like RecoveryCompleted which should not update the state.

Could you please clarify when it is necessary to update the state in a ReceiveRecover method?

I have seen the pattern of extending a class through inheritance by deriving the class from a base class of similar type. For example, in WebAPI a CustomerController is derived from APIController. The class Extension and ExtensionProvider has confused me. To me, it is more like configuring a run time object but the name Configure would have been more appropriate?

Could you please explain the CqrsExtension achieved with InjectTopLevelFallback?

Is AddressBook equivalent to an IoC Container where singleton instances of coordinators and routers are managed?

While I'm running the application locally, I don't see any response after this line

child.Forward(command);

The sign up page returns with a 500 Internal Server Error and simply don't proceed from there.

I noticed that monitoring is integrated with the application. But I don't see any logs in the Visual Studio output window neither any logs in the BIN or OBJ folder.

Could you please let me know if I have to install any special software like Kamon and Stasd to see the logs?

I updated the HOCON to the following. I still don't see any logs in the output window:

  <akka>
    <hocon>
      <![CDATA[
        akka {
          loglevel = DEBUG
          loggers = [ "Akka.Logger.Serilog.SerilogLogger, Akka.Logger.Serilog" ]
          actor {
            autoreceive = on
            lifecycle = on
            fsm = on
          }
        }
      ]]>
    </hocon>
  </akka>

Is the role of AggregateCoordinator a supervisor?