Comments (6)
Thanks again for the suggestion! Implemented in 3.7.0
🚀
If you have more suggestions - you are welcome to create issues/PRs!
from just-validate.
Hi! Yeah great suggestion! Your solution will work, also yeah we could do it as string | string[]
and check if it's an array. Would be useful.
I really appreciate pull requests - if you could do that, you are warmly welcome! :)
from just-validate.
Great, thank you!
from just-validate.
Thank you, this is working great, however, I did find a potential issue. If the user accidentally adds multiple spaces between the class names, an error will be thrown. A quick pass through .filter()
should take care of it:
Just-validate/src/utils/helperUtils.ts
Line 46 in ed08c65
tweaked to:
list.push(...classList.split(' ').filter(cls => cls.length > 0));
(with the .filter()
, .trim()
is no longer necessary)
I get that technically it's a user error, but if you don't know what the code is doing behind the scenes it may not be obvious, and it's such a simple preventative fix.
Thanks again!
from just-validate.
Good catch, indeed! Fixed, thanks!
from just-validate.
Thank you!
from just-validate.
Related Issues (20)
- Method unlockForm HOT 2
- Recaptcha Validation HOT 1
- Additional Rules/Validators on Groups (Not just required) HOT 3
- Cannot use this library in core typescript project HOT 3
- Provide unminified js version with named export HOT 2
- Undefined error message HOT 4
- showErrors not working on groups HOT 1
- Reset form input value
- when input hidden deal with script HOT 1
- QUESTION - How to use `revalidate` to stop user navigation if form is invalid? HOT 7
- Number rule should support locale number format
- Trigger validation and error messages via javascript HOT 1
- Silent revalidate HOT 2
- docs: provide more detailed explanation with images or code
- Compatibility with Vue 3? HOT 4
- Radio input required and other inputs HOT 1
- Can't have this regexp to work whatsoever
- Form Won't Submit HOT 1
- showErrors: Field not found if using diferrent selector in addField()
- Skip validation rules for fields that are hidden with CSS HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from just-validate.