Git Product home page Git Product logo

Comments (6)

horprogs avatar horprogs commented on May 25, 2024 1

Thanks again for the suggestion! Implemented in 3.7.0 🚀

If you have more suggestions - you are welcome to create issues/PRs!

from just-validate.

horprogs avatar horprogs commented on May 25, 2024

Hi! Yeah great suggestion! Your solution will work, also yeah we could do it as string | string[] and check if it's an array. Would be useful.

I really appreciate pull requests - if you could do that, you are warmly welcome! :)

from just-validate.

erobertson42 avatar erobertson42 commented on May 25, 2024

Great, thank you!

from just-validate.

erobertson42 avatar erobertson42 commented on May 25, 2024

Thank you, this is working great, however, I did find a potential issue. If the user accidentally adds multiple spaces between the class names, an error will be thrown. A quick pass through .filter() should take care of it:

list.push(...classList.trim().split(' '));

tweaked to:

list.push(...classList.split(' ').filter(cls => cls.length > 0));

(with the .filter(), .trim() is no longer necessary)

I get that technically it's a user error, but if you don't know what the code is doing behind the scenes it may not be obvious, and it's such a simple preventative fix.

Thanks again!

from just-validate.

horprogs avatar horprogs commented on May 25, 2024

Good catch, indeed! Fixed, thanks!

from just-validate.

erobertson42 avatar erobertson42 commented on May 25, 2024

Thank you!

from just-validate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.