hooqtv / fished Goto Github PK

In current algorithm, fished will map rules to a index:
example if we have input : ["A", "B"] it will be transform into { "A": [1], "B": [1] } (assume only one rule and in index 1 in the rule arrays) at runtime if both "required parameters" are met the rule will fire. In this case because the rule is successfully verified for both of these inputs, it will be fired twice hence double execution.

We need to have functionality of managing multiple results from an expression.

Currently caching parsed rules only cached as long as the rule has not been changed. It is better to treat each of the rule individually.
we can use help of LRU (https://github.com/hashicorp/golang-lru)

Fine work boss @JonathanSudibya. Looking at the test, I think testing a more complex rule might illustrate the engine's capability even better. For example, a common scenario is testing a rule that contains calling an API. Here is such scenario:

{
    "input": ["pokemon_name"],
    "output": ["pokemon"],
    "rule": "getPokemon(pokemon_name)",
    "value": "???"
},
{
    "input": ["pokemon"],
    "output": ["isGoodPokemon"],
    "rule": "['dragon', 'fairy'].includes(pokemon.type)",
    "value": "true"
}

From the above sample, some questions arose:

1. How to call an API inside the rule?
2. How to store pokemon data fetched from the API to the output?
3. How to store pokemon data (that is probably a struct that contains a lot of attributes?
4. How to check array inclusion as seen in the second rule?
5. How to handle error that we might get from calling the API?