hongpong / broken-link-checker Goto Github PK

It is not easy necessarily to include libraries from Composer, they may have to be manually namespaced.

• https://stackoverflow.com/questions/50144816/3rd-party-dependency-conflict-in-developing-wordpress-plugin
• http://selfteach.me/install-wordpress-plugins-composer/

See also #21 as this plugin will need a composer.json file as well to operate this correctly (and thus will need to know its namespace if it has the original or a new fork one)

Recommended by @mlang38 here:

• https://github.com/ManageWP/broken-link-checker/issues/44

We have switched to HTTP/2 with Let's Encrypt recently.

I guess the problem comes from the Snoopy library which doesn't seem to be really maintained anymore. I suggest switching to HTTPlug with something like Guzzle to implement it.

Don't know if it will solve HTTP/2 and encryption issues, but I think it will be more reliable for the future.

Would be nice to set custom alerts. more info here:

• https://www.wpsecurityauditlog.com/support-documentation/create-custom-alerts-wordpress-audit-trail/

via @paulschreiber :

paulschreiber@132cc2b

the new one is here https://github.com/alexei/sprintf.js

currently located at js/sprintf.js 2007 edition

Hi,
I am using the latest version from github. Recently I have received a following email from cron:

Error Table 'mysite.wp__blc_instances' doesn't exist bazy danych WordPressa podczas wykonywania zapytania SELECT instance_id FROM wp__blc_instances WHERE container_id = 18154 AND container_type = 'post' wysłanego przez do_action_ref_array('wp_scheduled_auto_draft_delete'), WP_Hook->do_action, WP_Hook->apply_filters, wp_delete_auto_drafts, wp_delete_post, do_action('delete_post'), WP_Hook->do_action, WP_Hook->apply_filters, blcPostTypeOverlord->post_deleted

It hasn't appear even once with the "old" version.

https://github.com/sbaresearch/advisories/tree/public/2019/SBA-ADV-20190913-02_WordPress_Plugin_Broken_Link_Checker

Improving testing on the plugin would make all development more stable and reduce chance of regressions. Note this would require a site populated with content that has both valid and 404 outgoing links.

In this I am inspired by the testing code on Linkback for Drupal 8 which is very detailed for all functions.

• https://make.wordpress.org/cli/handbook/plugin-unit-tests/
• https://torquemag.io/2018/06/advanced-oop-for-wordpress-part-6-continuous-integration-for-wordpress-plugins/
• https://carlalexander.ca/continuous-integration-wordpress/
• https://www.smashingmagazine.com/2017/12/automated-testing-wordpress-plugins-phpunit/
• https://generalchicken.net/wp-codeception-tutorial/your-first-cept-acceptance-test/

very nice to see someone willing to maintain this plugin

from your comments on WP and your request to transfer ownership, it's unclear to me what the status of this BLC repo is - are you forking it? or just patching it?

i wasn't able to find a license for the original BLC, however given the authors lack of presence i hope you see fit to take over the project and re-release it

i'd like to submit 1 or 2 issues but would like to know the status first

thanks!

reported by @johnny538 a few months ago here
https://wordpress.org/support/topic/php-errors-135/

PHP Notice: Trying to get property of non-object in /var/www/html/wp-content/plugins/broken-link-checker/includes/any-post.php on line 298

please fix

a lot of times this kind of notice can be fixed by isset() or property_exists() , however not sure if that would matter because $post is checked for emptiness first ( http://php.net/manual/en/function.empty.php ) . Maybe post is somehow not an object here.

see also https://wordpress.stackexchange.com/questions/88613/notice-trying-to-get-property-of-non-object-in-options-php

looks to me like this

        if ( empty($post) || !in_array($post->post_type, $this->enabled_post_types)) {

Perhaps $post is not empty and $this is unset. That would lead to this condition. More careful checking of the nature of $this may be needed since this could be triggered in an odd place?

• entering a debug statement, or var_dump($post) and var_dump($this) might be needed to figure this out.
• Also need to know WP and PHP versions in play here.

Improve situation by listing all the files and functions and how the various modules are instantiated. (as seen in some other modules i have worked on such as Drupal.org/project/ices )

Safe mode is long gone. All references should be removed.

• http://php.net/manual/en/features.safe-mode.php

Google Video has been removed (sad) and the module should be removed as well.

"If you have Amazon affiliate links, it will keep showing them as forbidden ones no matter how many times you click to ignore"

via gooma2 here https://wordpress.org/support/topic/request-to-transfer-ownership-of-broken-link-checker/

Time for GPL license file to be added (v2 or v3)

should aim to have a null date field work just fine. DB schema would have to be incremented (there are spots in code that check for schema)

originally reported by @ghost in 2017:

• https://github.com/ManageWP/broken-link-checker/issues/39

The default db-schema.php has columns like:

`first_failure` datetime NOT NULL DEFAULT '0000-00-00 00:00:00',
`last_check` datetime NOT NULL DEFAULT '0000-00-00 00:00:00',
`last_success` datetime NOT NULL DEFAULT '0000-00-00 00:00:00',
`last_check_attempt` datetime NOT NULL DEFAULT '0000-00-00 00:00:00',

However, in MySQL 5.7, NO_ZERO_DATE in conjunction with strict mode are defaults. This means that the above schema settings are invalid in a standard MySQL 5.7 installation.

Is there a code-dependent reason for them being set to default to zero?

If not, I think a more compatible schema would be to make them nullable.

• see https://wordpress.stackexchange.com/questions/67345/how-to-implement-wordpress-plugin-update-that-modifies-the-database

until we know if it can be transferred or forked this should wait. right idea:

jigawot@91a0f64

Want to have good assets for plugin banner and icon.

• https://developer.wordpress.org/plugins/wordpress-org/plugin-assets/

this site can generate lots of status response codes and also slow responses easily

• https://httpstat.us/

an ideal CI script would install the site and fire off requests to this service and record that they came back and registered correctly.

The library is out of date for internationalization. The real one is last updated in 2015 but the one in here is from 2008. Original website cannot be reached, these are the new ones.

• new https://github.com/algo26-matthias/idna-convert
• http://idnaconv.net

by Matthias Sommerfeld [email protected]

Ideally this should have a good testing system available as well (separate issue should be filed).

the plugin is altering the PHP environment values and this is a pretty serious intervention in the environment. May want to somehow change how this is set up. Or throw more warnings if it is engaged. And per this report it happens even if the plugin is not active. (given the better batch handling in the fork this may not even be needed anymore. the jobs seem to move along okay without these extreme settings, that can cause other problems elsewhere)

https://wordpress.org/support/topic/plugin-settings-override-server-and-wp-config-even-when-deactivated/

خطأ Table 'newsliby_wp.wp__blc_instances' doesn't exist في قاعدة بيانات ووردبريس للاستعلام SELECT instance_id FROM wp__blc_instances WHERE container_id = 7087 AND container_type = 'post' القادم من do_action_ref_array('wp_scheduled_auto_draft_delete'), WP_Hook->do_action, WP_Hook->apply_filters, call_user_func_array, wp_delete_auto_drafts, wp_delete_post, do_action('delete_post'), WP_Hook->do_action, WP_Hook->apply_filters, call_user_func_array, blcPostTypeOverlord->post_deleted

i went to install the latest version from this repo but i see in WP that i have 1.11.8 installed and this repo is 1.11.7, yet the code here was updated after .8

can someone help me understand?

When ready to post new version for community use "Deployer" to tag releases into SVN

• https://deployer.seravo.com/

Alternative:

• https://github.com/mikejolley/github-to-wordpress-deploy-script

More info:

• https://brianhogg.com/maintain-update-free-wordpress-org-hosted-plugin-using-git/
• https://codex.wordpress.org/Using_Subversion
• https://developer.wordpress.org/plugins/wordpress-org/how-to-use-subversion/

Getting some kind of integration with WP-CLI would be very helpful for most people, even if it is just status readouts to start with. Also tests should be included. Certainly if this plugin is widely used, this would help a lot.

• https://make.wordpress.org/cli/handbook/internal-api/wp-cli-add-command/
• https://make.wordpress.org/cli/handbook/plugin-unit-tests/
• https://developer.wordpress.org/cli/commands/scaffold/plugin-tests/
• Equiv for themes: https://developer.wordpress.org/cli/commands/scaffold/theme-tests/
• https://deliciousbrains.com/deploying-wordpress-plugins-travis/
• https://johnblackbourn.com/reducing-travis-ci-build-times-for-wordpress-projects/
• https://www.tychesoftwares.com/a-look-at-how-woocommerce-tests-using-continuous-integration/
• https://wordpress.org/plugins/gitium/ and https://www.presslabs.com/code/gitium/
• https://shubhampandey.in/integrating-travis-ci-wordpress-theme/
• https://seravo.fi/2015/continuous-integration-testing-for-wordpress-plugins-on-github-using-travis-ci
• https://joemcgill.net/2017/02/setting-wordpress-tests-circleci-wp-cli/

follow readme best practices:

• https://developer.wordpress.org/plugins/wordpress-org/how-your-readme-txt-works/

For now will keep the original name intact, but I have another nice new name if they won't transfer ownership. 😉

Clean up Facebook internet pollution by removing ?fbclid= query strings.

• Should be configurable user option
• needs to get if fbclid is the only query string
• needs to preserve other query strings than fbclid

utm style links could also be cleaned but fbclid should be the first one attempted.

Ideal: https://addons.mozilla.org/en-US/firefox/addon/neat-url/ (GPL)

this is an old jQuery.cookie version. should probably be this one

https://github.com/js-cookie/js-cookie/releases/tag/v2.2.0

see

• https://github.com/ManageWP/broken-link-checker/issues/56
• https://wordpress.org/support/topic/links-to-youtube-videos-403-access-not-configured/

any PR welcome on this. some quick fixes listed at second link

/modules/checkers/http.php
line 194, 195:

//Add a semi-plausible referer header to avoid tripping up some bot traps
curl_setopt($ch, CURLOPT_REFERER, home_url());

i'd like to change the referer to google to see if i can avoid some '403 Forbidden' results (vimeo.com) - how do i do this - is the following correct:
curl_setopt($ch, CURLOPT_REFERER, 'google.com');

or do i need to keep the brackets:
curl_setopt($ch, CURLOPT_REFERER, 'google.com'());

PHP 7.1 should be required since all other PHP versions are now end-of-life.

• http://php.net/supported-versions.php
  PHP 7.1 is EOL 'security fixes only' until December 1 2019 then it should be changed to require PHP7.2.

This will reduce maintenance overhead and prevent problems with modern hosting.

This would not be done immediately but I think would be OK to do after about two releases (like two or three months out from the next, revamped release)

this patch may be worth doing via @Pathduck

Pathduck@2e754a0

path to languages is missing

• https://developer.wordpress.org/plugins/plugin-basics/header-requirements/

Too many CSS elements are inadequately differentiated from general markup. Everything should be prefixed with blc-- if not already.

• Block Element Modifier is the preferred approach. https://css-tricks.com/bem-101/

Certain hosts including WP Engine ban the plugin. Which ones? This should be determined and if there is a way to get back in their good graces.

plugins are expected to follow the code of conduct

• https://developer.wordpress.org/plugins/wordpress-org/detailed-plugin-guidelines/
• https://make.wordpress.org/community/handbook/wordcamp-organizer/planning-details/code-of-conduct/

Hi,
This plugin doesn't like redirect with cookies.

Just add to your site a few links like:
http://physrev.physiology.org/content/81/3/1031.full
http://www.fasebj.org/content/25/1_Supplement/528.2
https://www.nature.com/articles/pr201551

There is a quick fix to get rid of some of those errors. In the file broken-link-checker/modules/checkers/http.php around line 200 add another parameter to CURL:

curl_setopt($ch, CURLOPT_COOKIEFILE, "");

This causes curl to accept cookies and to store them temporarily in the memory. That is fine and it is enough.

It solves some issues, the problem remains with some links and their logic. Because BLC reports me as a redirect link which eventually gets redirected to itself. I think there has to be a check if the final url equals the original url, then there is nothing to report and it is not a redirect, despite there are different url's in between (for example to set cookies).

I will try to to add this logic to BLC a little bit later.

Need to make sure linted as tightly as possible.

• https://wordpress.org/plugins/php-compatibility-checker/

a PR ready to go
https://github.com/ManageWP/broken-link-checker/pull/53

this should really be a 302 "Moved Temporarily". at /includes/links.php line 74

        302=>'Found',

in some cases a remote host may not give the same results for a HEAD request instead of a regular GET request.

• make an option to process an individual link as a GET request
• make an option to make a default sitewide use of GET request instead of HEAD (which takes more resources. this would not be a module default)

per the discussion here @Pathduck ran into this kind of issue with a remote host probably. https://wordpress.org/support/topic/help-sites-who-always-show-redirect/

This isn't a high priority for me and would probably be after #24 for ease of proper development, however I wanted to get the idea established.

/core/core.php lines 370 to 1300 should be moved to a separate file. Saturated with HTML inline markup.

See also #24. Guzzle should be able to do this (curl probably can as well with the right args). It would need an interface in the options to load cookie strings most likely, or in some cases just fake its way thru accepting cookies better.

Issue filed here: https://wordpress.org/support/topic/cookies_not_supported/ by @grzegorzjanoszka :

Hi,
I really like this plugin and it helps me to provide reliable sources to information on the Internet. There are more and more websites however doing funny stuff with HTTP requests and they set cookies and require them.
This plugin unfortunately doesn’t support it and as a result I have lots of redirects to URL’s containing:
– ?error=cookies_not_supported
– /action/cookieAbsent
– sth similar
Any idea how to cope with that?
Thank you in advance for any help.

Part of this commit:

https://github.com/wpmudev/broken-link-checker/commit/c6ee7f2b86c0b8824c582e969600e1b832a3667e

spinoff from #44

Some may be already fixed by upstream fork contributors.

Originally reported in 2016 by @mAAdhaTTah and @era5mx :

• https://github.com/ManageWP/broken-link-checker/issues/3

Getting this message for a number of classes:

[23-Jan-2016 20:04:15 UTC] PHP Deprecated:  Methods with the same name as their class will not be constructors in a future version of PHP; blcModule has a deprecated constructor in /path/to/plugins/broken-link-checker/includes/module-base.php on line 15
[23-Jan-2016 20:04:15 UTC] PHP Stack trace:
[23-Jan-2016 20:04:15 UTC] PHP   1. {main}() /path/to/wp/wp-admin/admin-ajax.php:0
[23-Jan-2016 20:04:15 UTC] PHP   2. require_once() /path/to/wp/wp-admin/admin-ajax.php:22
[23-Jan-2016 20:04:15 UTC] PHP   3. require_once() /path/to/wp/wp-load.php:42
[23-Jan-2016 20:04:15 UTC] PHP   4. require_once() /path/to/wp-config.php:9
[23-Jan-2016 20:04:15 UTC] PHP   5. do_action() /path/to/wp/wp-settings.php:392
[23-Jan-2016 20:04:15 UTC] PHP   6. blc_init() /path/to/wp/wp-includes/plugin.php:525
[23-Jan-2016 20:04:15 UTC] PHP   7. require_once() /path/to/plugins/broken-link-checker/core/init.php:303

Getting this message for a number of classes:

[23-Jan-2016 20:04:15 UTC] PHP Deprecated:  Methods with the same name as their class will not be constructors in a future version of PHP; blcModule has a deprecated constructor in /path/to/plugins/broken-link-checker/includes/module-base.php on line 15
[23-Jan-2016 20:04:15 UTC] PHP Stack trace:
[23-Jan-2016 20:04:15 UTC] PHP   1. {main}() /path/to/wp/wp-admin/admin-ajax.php:0
[23-Jan-2016 20:04:15 UTC] PHP   2. require_once() /path/to/wp/wp-admin/admin-ajax.php:22
[23-Jan-2016 20:04:15 UTC] PHP   3. require_once() /path/to/wp/wp-load.php:42
[23-Jan-2016 20:04:15 UTC] PHP   4. require_once() /path/to/wp-config.php:9
[23-Jan-2016 20:04:15 UTC] PHP   5. do_action() /path/to/wp/wp-settings.php:392
[23-Jan-2016 20:04:15 UTC] PHP   6. blc_init() /path/to/wp/wp-includes/plugin.php:525
[23-Jan-2016 20:04:15 UTC] PHP   7. require_once() /path/to/plugins/broken-link-checker/core/init.php:303

Name: Broken Link Checker

FILE: /.../wp-content/plugins/broken-link-checker/includes/admin/table-printer.php

FOUND 1 ERROR AFFECTING 1 LINE

28 | ERROR | Deprecated PHP4 style constructor are not supported since PHP7

FILE: /.../wp-content/plugins/broken-link-checker/includes/utility-class.php

FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE

42 | WARNING | INI directive 'safe_mode' is deprecated from PHP 5.3 and forbidden from PHP 5.4.

FirePHP references should be removed. Modern debugger is better.

See:

• http://selfteach.me/debug-php-wordpress/
• https://wordpress.org/plugins/wp-php-console/
• https://github.com/unfulvio/wp-php-console
• optimal debugging via console: https://developer.mozilla.org/en-US/docs/Tools/Web_Console/Console_messages

Vimeo should be updated. at modules/extras/vimeo-embed.php

		$this->url_search_string = 'vimeo.com/moogaloop.swf?';