honeyfox / engineignitor Goto Github PK

Hey HoneyFox!

I love your work, but I've always found it a little tricky needing to figure which configs to extract from the PressurizedFT and Ignitor Configs files.

I was wondering if we'd be able to simplify things? I know that ModuleManager these days allows for :NEEDS and :AFTER configs, so it strikes me that we can install all the ignitor configs and pressurized tanks by default, and by using appropriate MM filters only have them apply if the required parts packs are installed. This would greatly simply installation to unzip into GameData.

I'm not familiar with the ignitor configs provided by RealFuels, but if there's always a single way this should be done (ie, always use RF configs if installed), then we should be able to do the same here. (Mentioning @NathanKell in case of any RF insights.)

I do have an ulterior motive, which is that I want to be able to test EngineIgnitor as part of my work on the CKAN, and embedded zip files unfortunately cause troubles when it comes to automated installs.

Many thanks again for all your great work!

~ Paul

Just been looking through your code, noticed a bug:

public void Reset()
{
ullageHeightMax = 0.05f; ullageHeightMax = 0.95f;
ullageRadialMin = 0.0f; ullageRadialMax = 0.95f;
}

Shouldn't this read ullageHeightMin ?
In any case, setting the max twice isn't what you're intending I'm sure 😄