Allow casks to opt-in to forcibly quit during `brew upgrade` about brew HOT 9 OPEN

Here's the related PR: #16507

from brew.

Seems reasonable to me but defer to @Homebrew/cask folks.

from brew.

skipping these stanzas (uninstall quit, and uninstall signal) was a recent change, because apps such as Visual Studio Code should not be forcibly closed as it is likely to cause a loss of work. And we were seeing an increase in PRs to add the stanzas.

Adding the ability to specify that the stanza should fire on upgrade makes sense to me, but the criteria for when this should apply could be difficult to determine. I would suggest that the loss of work is the item that matters most.

from brew.

Adding the ability to specify that the stanza should fire on upgrade makes sense to me, but the criteria for when this should apply could be difficult to determine.

Opt-in with a new DSL makes sense to me here.

What happens on uninstall?

from brew.

On uninstall we do run the quit and signal directives, but not on upgrade or reinstall.

from brew.

@bevanjkay Gotcha. Could you dig up the PR that changed this, too?

from brew.

Thanks @bevanjkay. Yeh, I think a new DSL/parameter is warranted here.

from brew.

Can you think of an existing dsl that has a similar parameter I can use as a guide?

from brew.

@bevanjkay depends_on I think is the best model here? It may be more complicated than you need, though. Feel free to hack something together and open a very early draft WIP PR and I'll help you from there 👍🏻

from brew.