Can't find socket when using emacsclient as homebrew editor about brew HOT 10 OPEN

PRs welcome -- if you're game to give it a try, we'd be happy to help you finish off even a half-working attempt.

Sure, will give it a try when I am free.

from brew.

But we should try fixing this for brew edit. PRs welcome -- if you're game to give it a try, we'd be happy to help you finish off even a half-working attempt.

Agreed. Please scope this logic entirely into dev-cmd/edit.rb if so, thanks!

from brew.

Original issue analysis is incorrect as the sandbox and build.rb doesn't apply here.

But there is overall environment filtering going on and setting HOMEBREW_TEMP does work: HOMEBREW_TEMP=$TMPDIR brew edit karabiner-elements. This perhaps should happen by default for brew edit but currently doesn't.

from brew.

Original issue analysis is incorrect as the sandbox and build.rb doesn't apply here.

Thank you for pointing this out.

But there is overall environment filtering going on and setting HOMEBREW_TEMP does work: HOMEBREW_TEMP=$TMPDIR brew edit karabiner-elements. This perhaps should happen by default for brew edit but currently doesn't.

Is there any side effect if the user sets HOMEBREW_TEMP to TMPDIR globally? Or do I need to wait for changes from brew edit?

from brew.

Is there any side effect if the user sets HOMEBREW_TEMP to TMPDIR globally?

It could break some builds that get confused by the long paths that TMPDIR typically point to.

If you don't build anything from source you'll probably be fine. If you do encounter build failures, you can always try to unset HOMEBREW_TEMP.

from brew.

Thank you for your reply ;), then I will temporarily leave this issue open. Feel free to close it if your team thinks it should not be implemented for brew edit.

from brew.

You could probably also set

TMPDIR=/private/tmp

as a likely safer alternative (though I don't think HOMEBREW_TEMP=$TMPDIR is that unsafe either).

But we should try fixing this for brew edit. PRs welcome -- if you're game to give it a try, we'd be happy to help you finish off even a half-working attempt.

from brew.

Hi, after a rough reading of the edit command code I have some doubts.

I don't quite understand why HOMEBREW_TEMP=$TMPDIR brew edit karabiner-elements can work. How does setting HOMEBREW_TEMP affect the access to the sock file in TMPDIR by exec emacsclient? Is it because TMPDIR is reset to HOMEBREW_TEMP during command execution (not found in the code) or is there another reason?

from brew.

Is it because TMPDIR is reset to HOMEBREW_TEMP during command execution (not found in the code)

Yes, this is done by bin/brew.

from brew.

Is it because TMPDIR is reset to HOMEBREW_TEMP during command execution (not found in the code)

Yes, this is done by bin/brew.

But bin/brew is just filter TMPDIR and I miss up the logic that sets TMPDIR back to HOMEBREW_TEMP in dev-cmd/edit.rb or other places like

from brew.