home-assistant / service-hub Goto Github PK

View Code? Open in Web Editor NEW

11.0 25.0 14.0 1.67 MB

Monorepo for NestJS services

License: Apache License 2.0

Dockerfile 0.36% JavaScript 0.28% TypeScript 99.36%

hacktoberfest

service-hub's Introduction

service-hub

This is an all-purpose monorepo to handle our service needs.

Services

Bots

cla-sign

Receiver to handle CLA sign requests for the Home Assistant GitHub organization.

discord

Bot for the Home Assistant Discord server
Bot for the ESPHome Discord server

github-webhook

Webhook handler for all Home Assistant GitHub repositories
Webhook handler for all ESPHome GitHub repositories

Deployments

When a new release is created, a new container image is created and pushed to ghcr.io.

All deployments are defined in our deployments repository.

service-hub's People

Contributors

Stargazers

Watchers

Forkers

cogneato mvarrieur dubhad xpcom-bsd drthanwho rosemaryorchard moenaxel depoll raman325 petro31 c0ffeeca7 thefes

service-hub's Issues

Bot does not add label, link to sources & docs for integration

Looking at home-assistant/core#79639 I wondered why the bot didn't add a label although the user did add the integration name and a link to the docs.
Even after adding the label the bot did not add links to docs & sources.
Creating an issue so we don't forget to check it.

[FR] Code Owner Commands for Dependency Labels

The code owner commands are awesome, thanks.

Wanted to suggest adding one to add the Problem in Dependency label for issues that need upstream fixes before progressing.

(May not be the best place to discuss, please close if not).

CLA Bot - Issue with Regions

When trying to "sign" the CLA at this endpoint with the following request data

{"country":"Germany","email":"[...]","name":"[...]","github_username":"psuet","region":"Hessen","signing_for":"self","i_agree":"on","github_user_id":"7604288","pull_request":"home-assistant/supervised-installer#259"}

I recieved multiple Internal Server Errors (500). Once I removed my region and selected "Select State" in the form it worked.

Label dependency-bump is added when manifest.json is changed

It should only change if the requirements inside manifest.json changed.

Example PR: home-assistant/core#83705

Commands can't be executed if there is a mismatch in case between GitHub username and manifest user

service-hub/services/bots/src/github-webhook/handlers/issue_comment_commands/commands.ts

Lines 92 to 106 in 59d8820

 const invokerIsCodeOwner = ( 

 command: IssueCommentCommandContext, 

 manifest?: IntegrationManifest, 

 ): boolean => { 

 let integrationManifest = manifest; 

 if (!integrationManifest) { 

 const integrationDomains = Object.keys(command.integrationManifests); 

 integrationManifest = 

 integrationDomains.length === 1 

 ? command.integrationManifests[integrationDomains[0]] 

 : undefined; 

 } 

 return integrationManifest?.codeowners?.includes(`@${command.invoker}`); 

 };

My username is iMicknl, while apparently in the manifest.json it is written as @imicknl. Best would be to check case insensitive for usernames.

I will see if I can do a PR in the coming weeks, but would be good to log the issue already.

"Changing author info" link not working

This link:
https://docs.github.com/articles/changing-author-info
does not work anymore. Not sure if it's moved to somewhere else, or if it's removed.

https://github.com/home-assistant/service-hub/blob/9d003aade5dbe3b6f6b9aff086b79c9a81cfa547/services/bots/src/github-webhook/handlers/validate-cla.ts#L269C26-L269C26

The "small-pr" label doesn't update even if PR drops below or rises above threshold

I noticed in the core repo, it seems that the "small-pr" label automatically gets applied only when the pull request is first submitted. But I think it would be best if it automatically updated depending on updates to the PR. This could increase efficiency in identifying which pull requests can be reviewed quickly.

• Example dropping below the threshold: home-assistant/core#91763 (My own PR. Goes from 70 additions to 24)

• Example rising above the threshold: home-assistant/core#91943 (Goes from 25 additions to 57)

	const invokerIsCodeOwner = (
	command: IssueCommentCommandContext,
	manifest?: IntegrationManifest,
	): boolean => {
	let integrationManifest = manifest;
	if (!integrationManifest) {
	const integrationDomains = Object.keys(command.integrationManifests);
	integrationManifest =
	integrationDomains.length === 1
	? command.integrationManifests[integrationDomains[0]]
	: undefined;
	}

	return integrationManifest?.codeowners?.includes(`@${command.invoker}`);
	};