Comments (11)
sairon
commented on August 16, 2024
3
Sorry everyone, this is completely my fault. While it would be nice to have a way to catch errors like this in CI before add-ons are pushed to production (which happens automatically on PR merge), I believe it wouldn't happen if someone else were reviewing the PR. I missed the wrong config entry name in the config and as I thought it's in overall a simple change, I just carelessly merged it. Next time I will make sure to test every change before merging add-on PRs.
from addons.
antro31
commented on August 16, 2024
1
Same issue on my side. Reverted back to previous version.
from addons.
stehliner
commented on August 16, 2024
1
looks like the newly introduced option should be named cache-size= instead of cache= in file dnsmasq/rootfs/usr/share/tempio/dnsmasq.config (line 12)...
from addons.
koenraadhaedens
commented on August 16, 2024
1
No worries! We appreciate all the hard work you put in. Mistakes happen, and it's all part of the learning process.
Your dedication and commitment are valued. Thank you for taking responsibility and for your continued efforts.
Keep up the great work!
From: Jan Čermák ***@***.***>
Sent: maandag 27 mei 2024 17:09
To: home-assistant/addons ***@***.***>
Cc: Author ***@***.***>
Subject: Re: [home-assistant/addons] Add-on Dnsmasq fails to start after update to 1.8.0 (Issue #3609)
Sorry everyone, this is completely my fault. While it would be nice to have a way to catch errors like this in CI before add-ons are pushed to production (which happens automatically on PR merge), I believe it wouldn't happen if someone else were reviewing the PR. I missed the wrong config entry name in the config and as I thought it's in overall a simple change, I just carelessly merged it. Next time I will make sure to test every change before merging add-on PRs.
-
Reply to this email directly, view it on GitHub<#3609 (comment)> or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJVYLQV5MSAKRAFSXSYBBX3ZENEB3BFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOJIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVA4DKNBTGU4DIMMCUR2HS4DFUVUXG43VMWSXMYLMOVS2UMRTGE2TINBZGUYTNJ3UOJUWOZ3FOKTGG4TFMF2GK>.
You are receiving this email because you authored the thread.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
from addons.
ScottG489
commented on August 16, 2024
Do we not even just spin up these add-ons once as part of our testing process?
from addons.
AquaMorph
commented on August 16, 2024
This issue seems bad because it seems like there is zero testing before pushing out to production. I created a new config from the documentation and also hit this error. Maybe this is something that can be improved for future releases.
from addons.
MKtuzi
commented on August 16, 2024
Hello. Is the problem fixed? Can someone please explain the solution? Thank you.
from addons.
cannondale0815
commented on August 16, 2024
Yes, seems fixed. Just update to latest version.
from addons.
MKtuzi
commented on August 16, 2024
Thank you. Sorry, I can't.. : 'AddonManager.install' blocked from execution, no host internet connection
I haven't seen any serious discussion about the problem, which is probably not just me. Something happened after upgrading dnsmasq to 1.8.0.... After restarting.... only NabuCasa, same error.. No Up or Dn grades.
I'll sort it out somehow.. Thanks.
from addons.
embed-3d
commented on August 16, 2024
Thank you. Sorry, I can't.. : 'AddonManager.install' blocked from execution, no host internet connection I haven't seen any serious discussion about the problem, which is probably not just me. Something happened after upgrading dnsmasq to 1.8.0.... After restarting.... only NabuCasa, same error.. No Up or Dn grades. I'll sort it out somehow.. Thanks.
I had the same issues, after I updated to version 1.8.0 since my network relies on the dnsmasq service.
I basically reconfigured my network to not use dnsmasq as dns server and rebooted my homeassistant server (disconnect and reconnect the ethernet port should be also sufficient). Now an update to version 1.8.1 should be possible.
Afterwards I reconfigured my network again to use dnsmasq as dns server and everything worked again as expected.
from addons.
ScottG489
commented on August 16, 2024
Yeah absolutely no blame on anyone in particular. These things happen, so we should at least have some kind of sanity check testing as part of CI.
from addons.
Related Issues (20)
- Mosquitto error: received null username or password for unpwd check HOT 5
- Mosquitto: SIGSEGV on start after update to 6.4.1 HOT 8
- InnoDB error repeatedly causing MariaDB v10.11.6 to fail to startup. HOT 2
- Assist Microphone addon
- Matter server: Primary interface CLI option not honored
- OpenThread Border Router Network device only configuration could not be saved HOT 11
- DHCP server addon fails to start after (and before) resetting configuration HOT 3
- SiliconLabs Zigbee/OpenThread Multiprotocol Add-on FATAL Secondary Protocol v5 doesn't match CPCd Protocol v4 HOT 6
- File editor file size over web HOT 1
- Let's Encrypt with Gandi DNS challenge and API key not working in version 5.0.18 HOT 9
- Debug flag isn't showing in UI HOT 1
- Matter 6.1 error at update process HOT 2
- Silicon Labs Multiprotocol 2.4.5 CPCd version conflict HOT 2
- Whisper 2.1.0 does not work without an internet connection HOT 1
- Let'sEncrypt: dns-he: unable to set up DNS validation of subdomain HOT 2
- Addon DHCP for HA yellow should mention, or just set the interface to end0 rather than eth0.
- Eve energy device is permanently offline HOT 7
- Staging workflow is problematic HOT 2
- Let'sEncrypt ignores output directories HOT 1
- OpenThread Border Router high CPU usage HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from addons.