Feature request: player cleanup hooks about tryorama HOT 8 CLOSED

I think this is inevitable, since you are managing ports yourself rather than using the ones tryorama provides and injects as ConfigSeedArgs. But do you see a way to integrate this more tightly with tryorama?

from tryorama.

from tryorama.

Hmm yeah you're right it's not ideal to have to manage on your own. If you want to propose a pattern we can see if we can bake it in.

Actually though, why do you have to manage the ports on your own, rather than using the random ports tryorama provides?

Would it be enough for there to be a config getter on the Player so you can read out the config data at test time?

from tryorama.

from tryorama.

The interfacePort happens to be stored "privately" at player._instancePort, which you can access already. I agree that this, and other config, would be good to have as part of the stable API, and have it documented, but this may work for you for now.

see

from tryorama.

@maackle this does work! I think that variable may have been kept in a closure previously, hence my workarounds. This is definitely cleaner (see ref'd PR above).

So, I think the original request here is probably no longer needed- does it make sense for you to repurpose this issue as a feature request for access to the interface port for each player?

from tryorama.

@pospi that makes sense!

from tryorama.

I created a fresh issue #28 just to make the intention clearer, and it links to this one for context.

from tryorama.