the logging situation about tryorama HOT 6 CLOSED

I agree, so to be clear, WASM_LOGs should always be printed at log level debug, but not at info IMO.

from tryorama.

@Connoropolous Thank you for the diligent issues and tracing the problems up and downstream. I spent way more time on the TryCP logs and was in a rush when working on the local conductor logs.

I've fixed the conductor startup log issue and updated the readme with the env var.

I don't know about the log level, as I don't have good examples of what the log outputs coming from hc sandbox look like. Generally I think stderr.on("data") should output to info or error, whereas stdout.on("data") should output to verbose or debug. Errors need to be logged always, whereas what else comes from the conductor should be logs that are only required when details of the conductor process need to be inspected.

I would wait for the upstream holochain log issue to be fixed before modifying the log levels in Tryorama. What do you think?

from tryorama.

I'd consider logs from the WASM as debug output that you want to see when you're developing something. Once development is finished and with the tests running on a CI, it doesn't need to show. You'd come back to it when experiencing an error and wanting to look into the issue, when you set the log level to debug manually again.

Do you agree?

from tryorama.

So, there is a need to be able to see WASM_LOG type debug logs while running tryorama. For that we apparently need the stdout feed to be piped through, fed to the console again by tryorama

from tryorama.

Ah I see

from tryorama.

Coming back to this now, I've run a few tests where I output traces from a zome. Regardless of the level of the trace, they're all output in the console when running a test with Tryorama, without the need to set an env var or the like.

I agree, so to be clear, WASM_LOGs should always be printed at log level debug, but not at info IMO.

I disagree with myself here and think that all wasm logs should be printed at info level. As this is how it is wired right now, I'll close this issue.

from tryorama.