hoichi / chops Goto Github PK

Implement a proper non-watch mode, that is. Free resources and exit.

Recent example: path. fsWatcher parses source path into an object, but if a converter reads yfm and it has a property named path, it gets fucked over.

Of course, the core engine is supposed to be very flexible, so your should be able to override most anything, but maybe we should at least validate the data critical for the core components themselves.

indexBy for collections defaults to el => el.toString, which as ofted as not gives you [object Object]. Which, with the current implementation, makes the dictionary too short to ever reach expected length, so the emit never happens.

Gotta think of something when we properly implement the reaction to change.

Not sure we want to block execution and make subscribing to every output channel obligatory, but there’s a nagging suspicion we could lose shit if someone subscribes too late.

Possible solutions:

• Do make subscribing to every output channel obligatory (not so hot idea for 'template' channel on Renderer).
• Buffer the unclaimed baggage. Will consume memory, should be destroyed when freeing resources ($ToDo)
• ?

Maybe it was just me playing with file names but I should probably check if that’s the only case.

It should be installable with npm/yarn at least from this repo.

Say you send page instead of {action: 'change', page}. And then nothing. Just the faint rustle of files not being written.

In theory, abstracting the event system should take care of that, but, you know. Lest we forget.

Changed a markdown just now, and it seems like the changed is fired over and over.

Reproduce, locate, exterminate.

Here’s a simple example: /index.html, which now simply gets written to the root (of the current volume). Since we allow a user to do that with .convert(), we should check after her.

See also #6

Say,

    5|
    6| block header
  > 7|     ======
    8|     h1= page.title
    9|     ======
    10|

Unexpected token ===

Should write the error to console and maybe even to the html but not just crash like an idiot.

Allow it to be set up by consumer script, I guess.

And maybe add simple slice() for rss in the same stride.