Git Product home page Git Product logo

Comments (9)

hodgef avatar hodgef commented on July 24, 2024 1

Yup it's intentional - just so those that want to self-host/use a script tag can download the release and use the assets on the ./build folder. They're pretty light assets too so I thought it was fair enough to add them to version control

from simple-keyboard.

MadDeveloper avatar MadDeveloper commented on July 24, 2024 1

Ok, thank's you!

from simple-keyboard.

hodgef avatar hodgef commented on July 24, 2024

Could you elaborate a bit about the feature? And of course PRs are always welcome 👍

from simple-keyboard.

MadDeveloper avatar MadDeveloper commented on July 24, 2024

Instead of just having onclick and onmousedown events, I would like to add the possibility to handle same events with ontouchstart, ontouchend and ontouchcancel (will permits to handle many touch events in the same time, and having many keyboards on the same app (that's one of my today problem)).

from simple-keyboard.

hodgef avatar hodgef commented on July 24, 2024

That would be perfect, looking forward to it!
By the way, if you want to have multiple keyboards on the same app, check out these:

react-simple-keyboard:
https://codesandbox.io/s/github/hodgef/demo_npm_react-simple-keyboard_multiple-instances

simple-keyboard:
https://codesandbox.io/s/github/hodgef/demo_npm_simple-keyboard_dispatch-method

from simple-keyboard.

MadDeveloper avatar MadDeveloper commented on July 24, 2024

I saw this example about multi keyboards, but in my case I don't want to synchronise them, it's an interactive tactile table, and two clients in the same time can play with it, so I need to be able to handle two different inputs at the same time (which is not able by the native way).

from simple-keyboard.

hodgef avatar hodgef commented on July 24, 2024

I see, this is definitely a great addition to the source. I appreciate your willingness to put forward a PR. If you have any questions feel free to reach out!

from simple-keyboard.

MadDeveloper avatar MadDeveloper commented on July 24, 2024

Indeed I've one question. I don't see the build directory in the .gitignore, is it an oversight or voluntary? Is it required in order to be deployed on npm?

from simple-keyboard.

hodgef avatar hodgef commented on July 24, 2024

PR #35 has been approved! Thank you - I'm closing this one out :)

from simple-keyboard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.