Button Hold : Allow additional keys via options about simple-keyboard HOT 6 CLOSED

Hello @bdorninger,

We've got a similar request here: #1544

But I would suggest in the meantime to use the layoutCandidates option.
#1544 (comment)

Thanks!
Francisco Hodge

from simple-keyboard.

OK, wasn't aware because I would have looked for OPEN issues ;-)

Have solved my required feature with the help of a module overwriting some methods. However, this might be fragile using future versions of simple-keyboard

from simple-keyboard.

Sorry about the confusion - I normally close Proposals since I have the means to track them through the Enhancements project.

https://github.com/hodgef/simple-keyboard/projects/3#column-3744996

On my end there's no need to keep items open in that case. That being said everything is still searchable though Google or the Github search, and the status will be on the existing issue:

Glad you found an alternative approach to fit your needs! You can add unit tests on your end to make sure any future updates do not silently break it. But I would say that I do my best to keep the codebase stable.

Thanks,
Francisco Hodge

from simple-keyboard.

Thanks for clarifying this.
However, I'd have a PR solving this.
According to your guidelines, I am asking before submitting it ;-)

from simple-keyboard.

I appreciate that - but since it's an Enhancement, I would politely decline based on item 1:

1. Use PRs to fix issues. New features are discouraged as they bring more maintenance burden over time.

I am trying to limit the maintenance overhead (via new features) from this library - since it's been taking up quite a bit of time since 2018. Though you are free to publish a module for it. It will definitely help people searching for this functionality.

I might pick up new Enhancements for some possible major version, but that is not in the plans for now.

from simple-keyboard.

OK, then I'll have to leave it. The module I made is merely a workaround until that enhancement is implemented. I would not consider it being a good solution, as it overrides handleButtonMouseDown and handleButtonHold. If these methods change in your repo, the module might then corrupt simple-keyboard

from simple-keyboard.