Remove react peer dependency about simple-keyboard HOT 5 CLOSED

oh nice! Thanks!

from simple-keyboard.

@bpugh Correct! The library boilerplate uses React, but simple-keyboard itself is vanilla javascript and doesn't have that dependency.

from simple-keyboard.

Oh I see. Hmm maybe there is a way we could split it out? Maybe have the demo boilerplate in a subdirectory? since if someone is adding it to an Angular project they wouldn't want to see npm warnings that they're missing react as a peer dependency.

from simple-keyboard.

@bpugh You're right, that's something that must be corrected. I can take a look into it this week. If you want to have a go at it and submit a PR, I would gladly accept it !

Thanks for reporting it by the way! I totally missed the implications of this boilerplate dep.

from simple-keyboard.

Hello @bpugh,

This turned out to be easier than expected. Since the dist does not need React, I just removed it from the peerDependencies. React will still be in the devDependencies, as it is used to build the live demo.

Here's the commit: 9580191

The change is live as of ^2.3.11 and I've updated the demos.

e.g.: https://codesandbox.io/s/krzkx19rr

Regards,
Francisco Hodge

from simple-keyboard.