hobbs / ggh Goto Github PK

not 100% sure that this is a real issue though.

I have a Gerrit server and I am trying to use ggh script. When I clone a project I see following warning:

scp: hooks/commit-msg: No such file or directory

This is because SERVER does not have a file ~USERNAME/hooks/commit-msg
What is this file for and why it should be in my home dir?

Other people that do not have ssh (real ssh) access to the server have much more scaring warning:
Permission denied (publickey,gssapi-keyex,gssapi-with-mic,keyboard-interactive).

The scp should be either removed to some quiet fallback provided.

Does it make sense to have 'ggh update' command? It can be helpful to people who is too laze to update ggh script using wget

'ggh update' should be an equivalent to

cd dirnamewhere ggh``
wget --no-check-certificate https://github.com/hobbs/ggh/raw/master/ggh
chmod +x ./ggh

But I am not totally sure that this is a great idea.

In case if we are on a topic branch and this branch has been submited, "git prune-branches" should

1. checkout its parent branch and then
2. remove the topic branch

Here is a use-case:
start "foo1" / edit / add / commit / upload
submit
git pull / git prune-branches
--> at this point, "foo1" still exists

git checkout master / git prune-branches
--> "foo1" has been removed but this can be done on the previous step

Following commit fixes the issue: https://github.com/anatol/ggh/commit/6c29cd7f5dcef43f66e1ab438c45d04eaeae5af6

Currently if you want to start a new branch you should run

$ git start foo master

it would be a little bit more convenient to have a shorter form in case if you are already on the "remote" branch.

It means if user is already on master and master is unmodified then the previous command could be written as

$ git start foo

In case if a user on a topic branch it should return a error "you are on topic branch". If user wants to start a branch from modified master branch then it should be reported as well.

ggh script uses mix of spaces and tabs. There should be only 1 style.

I prefer spaces. Here is a commit that fixes the issue https://github.com/anatol/ggh/commit/d13227b0bf19f2e0479276883f45caae14a2189b