hoaproject / dispatcher Goto Github PK

https://github.com/hoaproject/Dispatcher/blob/master/Basic.php#L83-L88
In these lines, the operator @ prevents to raise errors, but if you put an custom error handler with this code :

set_error_handler(function ($errno, $errstr, $errfile, $errline ) {
    var_dump(func_get_args());
});

There is still an triggered error.

In order to prevent this, I suggest these line as replacement

    $call       = !empty($variables['controller']) ? $variables['controller'] :
                    !empty($variables['_call']) ? $variables['_call'] : $rule[\Hoa\Router::RULE_CALL];
    $able       = !empty($variables['action']) ? $variables['action'] :
                    !empty($variables['_able']) ? $variables['_able'] : $rule[\Hoa\Router::RULE_ABLE];

Hi, as you can see on hoa-project.net/Fr/Literature/Hack/Dispatcher there is a little error :)

Error: ...règle (voir string(23) "Rule lh does not exist."

Source: Documentation/Fr/Index.xyl#L24
...règle (voir <a href="@lh:chapter=Router">la bibliothèque <code>Hoa\Router</code></a> si...

As we can see on Hoa\Router doc the rule name should be hack.
See s/@lh/@hack commit in Hoa\Router.

I didn't do a PR because I can't test whether it's just that or not ;)

The Basic dispatcher is able to dispatch a request/task on several callables: function, closure, class+method, object+method…

The idea is to extract each one of these forms as a standalone dispatcher. Then, when they will be tested, we could introduce an Aggregate dispatcher. Finally, the Basic dispatcher would be a special usage of the Aggregate dispatcher that aggregates all the existing dispatchers.

The roadmap is:

• ensuring better performances for all dispatchers,
• ensuring better testability for all dispatchers,
• do not introduce BC break (not a lot at least, one is necessary, see incoming issues or PR),
• ensuring a better modularity by choosing/aggregating dispatchers.

Progress:

• Function (incl. Closure) dispatcher,
• ClassMethod dispatcher,
• ObjectMethod dispatcher,
• Aggregate dispatcher,
• Basic dispatcher.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Related to #11.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Related to #11.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Related to #11.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Related to #11.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Hey,

I have a Fatal Error : PHP Fatal error: Cannot mix bracketed namespace declarations with unbracketed namespace declarations in C:\www\sohapi\vendor\hoa\console\Dispatcher\Kit.php on line 37
I think its come from the Core , who still have file with namespace {} and namespace ;
I try to fix it, but when we declare namespace foo; we can't return on the global namespace namespace ;

And if we force tu use namespace Hoa\Core; all function defined on root can't be access ie ( dnew => \Hoa\Core\Consistence\dnew() )... i don't have any solution for it

Related to #11.