Git Product home page Git Product logo

Comments (4)

hnqiu avatar hnqiu commented on August 24, 2024

Hi Javad,
Glad to know my code is useful to you and thanks for the comments.

  1. It's a good idea to use a P-controller for x-vel. I will add the component a bit later.
  2. Actually we need pillar_pos to be used to update the marker position in vizPillar() at every step, because initPillarMarker() is only called during initialization. Please note pillar_pos is the relative position to the robot and is updated in the laser callback function.
  3. I guess it wouldn't matter. Why would you suggest so?

Thanks,
hnqiu

from ros-ethz.

Javad-111 avatar Javad-111 commented on August 24, 2024

Hi Hnqiu,
Thanks for the reply.
2. I agree with you, but I mean the first two line in vizPillar is repeated in the initPillarMarker. Isn't initPillarMarker called in every function loop?
3. because the msgwill be send before seting the forward velocity. Thus, the current command for forward speed will be used in the next time step. Although cause the time increments is very low, it is not sensible, and the program works.

Kind regards,
Javad

from ros-ethz.

hnqiu avatar hnqiu commented on August 24, 2024

Thanks Javad.

  • No initPillarMarker() is only called once at initialization.
  • The msg will only be sent to the topic in DriveHusky(), which is called in the laser callback function, which is AFTER initialization. Note callback functions execute when we call spinOnce().

Cheers,
hnqiu

from ros-ethz.

hnqiu avatar hnqiu commented on August 24, 2024

Hi Javad, I've updated the x-vel control in course 3 using a P controller. Thanks for opening the issue.

Cheers,
hnqiu

from ros-ethz.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.