Git Product home page Git Product logo

zap-ltsv's Introduction

zap-ltsv's People

Contributors

hnakamur avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

zap-ltsv's Issues

Fix option func names which stutters

https://travis-ci.org/hnakamur/zap-ltsv/jobs/196078900

Checking lint...
ltsv_encoder.go:304:6: type name will be used as ltsv.LTSVOption by other packages, and that stutters; consider calling this Option
ltsv_encoder.go:316:6: func name will be used as ltsv.LTSVTimeFormat by other packages, and that stutters; consider calling this TimeFormat
ltsv_encoder.go:323:6: func name will be used as ltsv.LTSVNoTime by other packages, and that stutters; consider calling this NoTime
ltsv_encoder.go:328:6: func name will be used as ltsv.LTSVTimeLabel by other packages, and that stutters; consider calling this TimeLabel
ltsv_encoder.go:335:6: func name will be used as ltsv.LTSVLevelLabel by other packages, and that stutters; consider calling this LevelLabel
ltsv_encoder.go:342:6: func name will be used as ltsv.LTSVNoLevel by other packages, and that stutters; consider calling this NoLevel
ltsv_encoder.go:347:6: func name will be used as ltsv.LTSVMessageLabel by other packages, and that stutters; consider calling this MessageLabel
ltsv_encoder.go:354:6: func name will be used as ltsv.LTSVReplacer by other packages, and that stutters; consider calling this Replacer

Two concerns.

  • If the LTSV encoder becomes a part of the original package, func name such as NoTime will collide with NoTime for the JSON encoder.
  • The zap-ltsv has the Replacer interface, so we can't rename LTSVReplacer to Replacer.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.