hmrc / address-lookup Goto Github PK

Hi,

I really like your service. I wanted to raise a tiny issue regarding the syntax for your array of address lines:

"lines": {
                        "type": "array",
                        "items": {
                            "type": "string",
                            "minLength": 1,
                            "maxLength": 35
                        },
                        "minLength": 1,
                        "maxLength": 3

If the 2 bottom properties are there to tell the consumer they need to populate the array with between 1 and 3 items in the array they should be minItems and maxItems (maxLength is used to control the length of strings). Please see JSOnschema draft 4 docs https://json-schema.org/understanding-json-schema/reference/array

Thanks again