hltech / judge-d-ui Goto Github PK

Scope

It should be visible after hovering on certain link on details view.

Scope

Right now root node is omitted from drawing when constructing consumers and providers trees of details view. It should be drawn as it may provide information about certain circular dependency cases. For better distinctiveness it could be drawn the same way as it is as a root node. In this case, root node should not have any further connections (to avoid drawing the same part of the graph recursively)

Hello,

I have come upon an idea of extracting part of this project responsible for rendering graph to an npm package. That would allow developers to install a judge-d-ui graph package in their projects and import graph component into their application, like:

import {GraphComponent} from 'judge-d-ui';

export const MyCustomGraphPage = () => {
  const [graphData, setGraphData] = useState();

  // ... fetch data for graph

  return <GraphComponent data={graphData} />;
}

Right now code responsible for showing graph is tightly coupled with data fetching, which narrows its usage to prepared demo purposes. I'd suggest extracting all components written for demo purposes outside of src (to /demo directory or something) and just leave presentational component there.

Tell me what do you think of this proposal.

Proposed solution

Use react-testing-library, render react component which mounts d3 nodes, then make asserts within this render

Scope

Overview graph can be zoomed in and out using keyboard, it should be implemented for details view as well

Scope

Right now links are colored the same way no matter what the contract type between two nodes is. Information about different contract types should be visually presented (different colors seem to work best in this case).

Details

Since there could potentially be infinite types of contracts and information about them should be consistent (should not change between sessions - this is why colors can't be generated on the fly), there should be a general classifier function which would return prepared colors for known types of contracts (like rest or jms) and return one color for all unspecified types of contracts.

Scope

There can be multiple nodes of same service on Overview Graph - each with different version. Right now while mapping nodes with links to build details view, service version is ignored. Version should be included not to present false information about node links (contracts may differ between service versions). Versions of all nodes should be taken into account while mapping data to details view.

Scope

Display clear relationship between nodes in regard of them being consumers / providers.

• maybe write docker-compose file to run backend+db+frontend at once for demo purpose