hlindberg / misc-puppet-docs Goto Github PK

Hello, I am experimenting with rewriting some of our old modules with the new arm-9 goodies.

I think the default hierarchy should have a ${operatingsystemmajrelease} in there somewhere. I deploy centos 5,6 and soon to be 7 boxes and the information and while a lot of module data can be shared with just the ${osfamily} there is quite a bit that does not quite fit.

I know that I can, and have, setup a custom binder_config.yaml to have the majrelease in there now. But I do think that this is something many people would also use. If you do not think so, feel free to close this issue.

Have a good day.

-Shawn

https://github.com/hlindberg/misc-puppet-docs/blame/master/data-in-modules.md#L549-L603

This passage started out so strong with the breakdown of the first component of the triplet. But as a reader I am immediately confused because the section on the second element leads off with a discussion of the third element. I would recommend you take the discussion on the third element and put it second, yes this is somewhat confusing but the reader will just roll with it since the first and third elements are easier to understand.

Also on L558 'actual' is probably meant to be 'actually'

https://github.com/hlindberg/misc-puppet-docs/blame/master/data-in-modules.md#L534

What is DCR_nbr? I've never heard of this? Is it a fact? Is it just nonsense that is meant to be incomparable with modulepath? If so, that should be footnoted or something.

Probably meant 'use' there.

https://github.com/hlindberg/misc-puppet-docs/blame/master/data-in-modules.md#L488

I'm pretty sure you meant user or something but lol

https://github.com/hlindberg/misc-puppet-docs/blame/master/data-in-modules.md#L562