hirschi-dev / renogy-rover-arduino Goto Github PK

The latest Arduino 1.8.19 needs a new attribute line in the library.properties

paragraph

Example
paragraph=Arduino MODBUS Driver for the Renogy Rover 20A/40A Charge Controller

Hi. I've been using your renogy interface for a few days on my Arduino
I have a Renogy 20A MPPT and RS232-TTL convertor and Arduino Uno and NRF24L01 wireless.
I noticed that after a few hours of continuous polling, the Arduino was send out corrupted data over the wireless.
(from my programming background) I worked out it was the getBatteryState and getPanelState and getProductName are mssing the free(values) at the end of the functions. You are calling "new uint16_t[registerLength];" which Arduino does a malloc, but it is not being released.
I added free() at the end to the three functions as a test and it us running without problems for thousands of polling now.

I also think you need to add the free() if the readHoldingRegisters fails.
eg.
if (!_readHoldingRegisters(registerBase, registerLength, values)) {
free(values);
return 0;
} else

Do you have an example file for this you could share? I'm struggling to get the library to compile properly in the IDE

Hi any idea if this library will work with Renogy 10 Amp model?
Also as you might know the Renogy controllers comes with RJ11/RJ12 port (not a standard 9pin com port). I haven't found any RS232 to TTL Converter that has RJ11/RJ12 port. what converter have you tested this with during your development?
Thanks for your time