hiranchaudhuri / oolitestarter Goto Github PK

Is your feature request related to a problem? Please describe.
I'm frustrated when I first start the software. I added the installed game location, but how am I supposed to know savegame directory or addons directory? WTH is "managed addons" and how are they different from unmanaged?

Describe the solution you'd like
Once you add your first Oolite installation, the rest of directories shall default to Oolite default paths.

Describe alternatives you've considered
Searching the forums for the proper values for all the paths. But it's a bit too laborsome.

Describe the bug
Windows executable available in the releases doesn't launch the integrated MSI installer. When normally executed, the exe installer launch a msiexec.exe process which takes care of everything. Since 0.1.27-fantail.2, the msiexec.exe is indeed launched, but does nothing, so the main process just hangs without any notice nor window. It appears as a closed app, but it can be seen in the Task Manager just waiting for msiexec.exe.

To Reproduce
Steps to reproduce the behavior:

1. Download any release from fantail.2 onward.
2. Double-click the exe. A window appears then immediately disappears (that is the expected behaviour with the previous releases).
3. No new window appears, the whole process seems to have shut down.
4. Open the Task Manager and see the OoliteStarter-0.1.27-fantail.4-Windows.exe process just waiting for one or two msiexec.exe to finish.

Expected behavior
MSI installer should launch like it did in previous releases.

Environment (please complete the following information):

• OS: Windows 10
• Java version: N/A
• OoliteStarter version 0.1.27-fantail.2+

Additional context
Ok, I will close this bug as soon as it is posted, since I found why it occurs. I didn't understand why the OoliteStarter installer on my fork worked but not the one here, since the two came from the same build process on GitHub.

The trick is: I don't know why, but my fork is labeled 0.1.0. I had to extract your release and launch the main.msi file using this command to get the log: msiexec /i "installer.msi" /l*v "log.log" The issue occurs because all of the fantail and obviously the final 0.1.27 have the same product version:

MSI (c) (D4:F4) [17:36:10:220]: Windows Installer reconfigured the product. Product Name: OoliteStarter. Product Version: 0.1.27.0. Product Language: 1033. Manufacturer: Unknown. Reconfiguration success or error status: 1638.

Therefore, the MSI installer fails to install the new versions on the basis that the 0.1.27.0 version is already installed. A poor OS indeed… The workaround for the user is just to uninstall the previous version before installing a new "patch" of the same version. I submit this bug report in order to help any user facing the same "bug".

Describe the bug
Should run-linux.sh use "java" instead of "javaw"? To the best of my knowledge this link shows why it would be better to use "java": https://stackoverflow.com/questions/14331406/why-javaw-is-not-found-on-my-java-installation-on-ubuntu

To Reproduce
Steps to reproduce the behavior:

1. From a terminal prompt in the OoliteStarter folder, execute run.sh or run-linux.sh
2. Error: "javaw: command not found"

Expected behavior
OoliteStarter should open

Environment (please complete the following information):

• OS: Ubuntu 22.04 with OpenJDK 18
• OS: Arch linux with OpenJDK 20
• OoliteStarter version 0.1.18

Describe the bug

When created by OoliteStarter (as in: not by Oolite itself), the ManagedAddOns folder is spelled ManagedAddons on Windows.

To Reproduce

Steps to reproduce the behavior:

1. Install OoliteStarter on Windows
2. Install Oolite on Windows
3. DO NOT start Oolite, instead start OoliteStarter
4. Follow the instructions provided by OoliteStarter to add a version of Oolite
5. Save this version
6. Check the name of the ManagedAddOns folder either in OoliteStarter, in the .oolite-starter.conf file, or at GNUstep/Library/ApplicationSupport/Oolite/ManagedAddons

Expected behavior

Should create a ManagedAddOns folder.

Environment (please complete the following information):

• OS: Windows 10
• Java not installed
• OoliteStarter version 0.1.25

Additional context

I stumble upon this while making a new install of Oolite on Windows, using OoliteStarter before launching Oolite for the first time. In that case, since the ManagedAddOns folder doesn't exist, OoliteStarter creates it under GNUstep/Library/ApplicationSupport/Oolite/ManagedAddons:

If you don't see the issue, look closer: the "o" must be uppercase. Why on Earth would we care since Windows isn't case sensitive? Because the Telescope OXP uses a Python script (or the exe conversion of said Python script) which is case sensitive, failling to find the required ManagedAddOns folder.

Describe the bug
The tab is stuck showing only the installed expansions. Change the filter and regex doesn't affect the list. Also, clicking reload doesn't work either.

To Reproduce
Just load the app and go to the expansion.

Expected behavior
The first time I used it it works as expected.

Screenshots

Environment (please complete the following information):

• OS: Ubuntu (POP OS) 22.04
• Java version not sure
• OoliteStarter version 0.1.21-elul.5

Currently the OoliteStarter user interface is powerful yet not very intuitive to be used.
Without question it evolved while features were added, and thus the handling is complex.

Let's look into how the U can be organized differently - more intuitive for the players - while still allowing most of the functionality.
One usable description is here:
http://aegidian.org/bb/viewtopic.php?p=293901#p293901

Is your feature request related to a problem? Please describe.
Right now, maximum_version is discarded:

The issue occurs with the combination of Telescope 2.14 and HUD Selector 1.26. Telescope is only in conflict with HUD Selector prior to 1.17:

{
	"identifier" = "oolite.oxp.Norby.HUDSelector";
	"maximum_version" = "1.17";
	"description" = "1.18 adds new feature (multiple HUD/worldScript); Telescope monkey patches for multiple MFDs";
}

So OoliteStarter marks the combination as a conflict, although the game runs fine. I checked, and Telescope is the only OXP to feature this parameter when not applying to an older version of itself. Therefore, it's not a bug, but could be a good feature.

Describe the solution you'd like
Store maximum_version. During the validateConflicts run, check if version is superior to maximum_version, and if so, drop the OXP from the list of conflicting expansions so it doesn't count as a conflict.

Describe alternatives you've considered
Rewriting the manifest.plist file of Telescope each time I update it, but if others OXP start to use this parameter it'll be a mess.

Describe the bug
There's a typo in the Flavors tab of the UI, it says "Play Oolite as close as possible to th original Elite."

To Reproduce
Steps to reproduce the behavior:

1. Go to the Flavors tab of the UI
2. See Vanilla description

Expected behavior
It should say "Play Oolite as close as possible to the original Elite."

Screenshots

Environment (please complete the following information):

• OS: Windows 11 amd64 10.0
• JVM: OpenJDK Runtime Environment 17.0.10+7
• OoliteStarter 0.1.28-uxbridge.12

Check the beginning of the logfile is unsure. That file resides in
$HOME/.Oolite/Logs

Additional context
N.A.

Describe the bug
Cancel doesnt work on "waiting for process to complete"

To Reproduce

1. Kill oolite.exe
2. attempt to cancel