hhelibeb / abap-fm-logger Goto Github PK

Improvements1：ZAFL_VIEWER
select single cust_name1, cust_name2, cust_name3
into corresponding fields of @config
from zafl_config.

Improvements2：
up to @pv_nofhs rows

Issue1:
if zcl_afl_utilities=>is_prd( )

error：A logical expression may not consist of just a method call.

Nice solution but it's missing support for changing parameters.

now if the log function is enabled, /afl/save will always perform a commit statement. That may cause data inconsistence issue in some certain condition.
need update readme and configuration to let use know a commit/rollback is necessary before /afl/save

the reprocess method can't restore the value of curr fields.

the macros is not easy to use.

if there is no IMPORT/EXPORT but the enable corresponding ZAFL_CONFIG option, a dump may occur.

rt

the code below will produce a syntax error,

FUNCTION z_fm.
  
  IF status = 'E'.
    /afl/save.
    RETURN.
  ENDIF.

  /afl/save.

ENDFUNCTION.

it should be fixed by moving the variable declaration to /afl/init.

despite this, i suggest to use a central exception management to handle exceptions.

FUNCTION ztest.
  
  /afl/log_init.
  
  TRY .
      class->method( EXPORTING p1 = p1
                               p2 = p2
                     IMPORTING results = results ).
    CATCH zcx_xx INTO DATA(msg).
      et_return[] = VALUE #( BASE et_return[] ( message = lo_msg->get_msg( ) ) ).
  ENDTRY.

  /afl/save.

ENDFUNCTION.

Hello,
First of all, thanks for sharing this tool!
Amazing work!

I am just doing some tests, and it seems that it's not ready for CHANGING parameters?

I dont see any columns for the CHANGING params in ZAFL_LOG and when trying to re-execute an FM with CHANGING param we have a dump.

Thanks again for sharing

“allow reprocess without authority check”
to avoid some potential product incidents

just like WE19

参考：SAP ABAP 派蒙-氢氦的开源项目 AFL abap fm logger 的 BUG 修复
预计过几天改一下

but exclude the HEADER LINE