hgmnz / heroku-pgupgrade Goto Github PK

Hi there,

I gave this a try, however, the pg:upgrade command won't work for me. In my setup, I've got an existing master that's running postgresql 9.0.7, and I did:

heroku addons:add heroku-postgresql:zilla --follow MASTER_URL # my master is a zilla as well
heroku pg:wait # waits until the new slave is caught up in commits
heroku maintenance:on
heroku pg:upgrade SLAVE_URL

When I run the upgrade command, I get:

! There were problems upgrading HEROKU_POSTGRESQL_ONYX
! database must be a newer follower. Please create and upgrade a new follower.

Running with the current heroku client, I get:

maciek@gamera:~/code/shogun$ heroku pg:upgrade orange -a shogun-maciek
/home/maciek/.heroku/plugins/heroku-pgupgrade/lib/heroku/command/pg.rb:9:in `upgrade': undefined method `resolve_db' for #<Heroku::Command::Pg:0x93ff274> (NoMethodError)
        from /usr/local/heroku/lib/heroku/command.rb:167:in `run'
        from /usr/local/heroku/lib/heroku/cli.rb:9:in `start'
        from /usr/bin/heroku:30:in `<main>'
maciek@gamera:~/code/shogun$ heroku version
2.26.3

fdr, running with an older client, has no issues.

Right now, pgupgrade strips the postgres role of replication privileges (to be confirmed, but a solid hypothesis). We should compensate for this in our pgupgrade plugin.