Git Product home page Git Product logo

mythicplusloot's Introduction

MythicPlusLoot

Add-on for World of Warcraft that adds the ability to see mythic plus item rewards per mythic plus level and item slot.

To install manually:

  • Create a MythicPlusLoot folder in your WoW AddOns folder and add the two files in this repository.

To access in game:

  • Type /mpl in chat or click the mini map button

mythicplusloot's People

Contributors

bluenightsky avatar chflick avatar gamer90 avatar herumph avatar hollicsh avatar hubbotu avatar kamusis avatar kpontussvensson avatar ramyrafik avatar yepitis avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar

mythicplusloot's Issues

loot table update 10.1

Hi, will this addon be updated for 10.1?, i can still see the loot from season 1 (i'm using last update )

Additions to the addon

Hey dude. Raid loot and perhaps a conduit "armor type" option would be a really cool addition to this addon.

General feedback

Took an initial look.

  • Theres a few items that are popping up that should not be there. Azerite pieces (think I noticed the cloth shoulders from mechagon). And a few legendary items from karazhan? Might be others, but this was a very quick ingame look on my part.

  • I'm abit worried about the usage of genericly named, public functions. You might want to look at using local functions to avoid any possible problems. Or, if you want them global, change to more uniquely named functions.

attempt to call method 'SetBackdrop' (a nil value)

Starting today I get the following LUA Error upon login in.

11x ...lusLoot/libs/LibUIDropDownMenu/LibUIDropDownMenu.lua:252: attempt to call method 'SetBackdrop' (a nil value)
[string "@MythicPlusLoot/libs/LibUIDropDownMenu/LibUIDropDownMenu.lua"]:252: in function `creatre_UIDropDownList'
[string "@MythicPlusLoot/libs/LibUIDropDownMenu/LibUIDropDownMenu.lua"]:391: in main chunk

Locals:
name = "L_DropDownList1"
parent = nil
f = L_DropDownList1 {
 0 = <userdata>
 Button1 = L_DropDownList1Button1 {
 }
 MenuBackdrop = L_DropDownList1MenuBackdrop {
 }
 Backdrop = L_DropDownList1Backdrop {
 }
 Border = L_DropDownList1Border {
 }
}
fbd = L_DropDownList1Border {
 0 = <userdata>
 PixelSnapDisabled = true
 OnBackdropLoaded = <function> defined @SharedXML/Backdrop.lua:152
 Center = Texture {
 }
 GetBackdropColor = <function> defined @SharedXML/Backdrop.lua:390
 SetupTextureCoordinates = <function> defined @SharedXML/Backdrop.lua:214
 OnBackdropSizeChanged = <function> defined @SharedXML/Backdrop.lua:182
 HasBackdropInfo = <function> defined @SharedXML/Backdrop.lua:278
 SetBackdropBorderColor = <function> defined @SharedXML/Backdrop.lua:422
 RightEdge = Texture {
 }
 backdropInfo = <table> {
 }
 BottomEdge = Texture {
 }
 GetEdgeSize = <function> defined @SharedXML/Backdrop.lua:188
 BottomLeftCorner = Texture {
 }
 BottomRightCorner = Texture {
 }
 TopEdge = Texture {
 }
 ApplyBackdrop = <function> defined @SharedXML/Backdrop.lua:294
 SetBackdrop = <function> defined @SharedXML/Backdrop.lua:329
 ClearBackdrop = <function> defined @SharedXML/Backdrop.lua:282
 TopRightCorner = Texture {
 }
 GetBackdropBorderColor = <function> defined @SharedXML/Backdrop.lua:409
 GetBackdrop = <function> defined @SharedXML/Backdrop.lua:347
 TopLeftCorner = Texture {
 }
 SetupPieceVisuals = <function> defined @SharedXML/Backdrop.lua:246
 SetBackdropColor = <function> defined @SharedXML/Backdrop.lua:399
 LeftEdge = Texture {
 }
 SetBorderBlendMode = <function> defined @SharedXML/Backdrop.lua:266
}
fmb = L_DropDownList1MenuBackdrop {
 SetBorderBlendMode = <function> defined @SharedXML/SharedTooltipTemplates.lua:203
 NineSlice = Frame {
 }
 TooltipBackdropOnLoad = <function> defined @SharedXML/SharedTooltipTemplates.lua:172
 GetBackdropColor = <function> defined @SharedXML/SharedTooltipTemplates.lua:191
 backdropInfo = <table> {
 }
 0 = <userdata>
 GetBackdropBorderColor = <function> defined @SharedXML/SharedTooltipTemplates.lua:199
 SetBackdropColor = <function> defined @SharedXML/SharedTooltipTemplates.lua:187
 layoutType = "TooltipDefaultLayout"
 SetBackdropBorderColor = <function> defined @SharedXML/SharedTooltipTemplates.lua:195
}
(*temporary) = nil
(*temporary) = L_DropDownList1MenuBackdrop {
 SetBorderBlendMode = <function> defined @SharedXML/SharedTooltipTemplates.lua:203
 NineSlice = Frame {
 }
 TooltipBackdropOnLoad = <function> defined @SharedXML/SharedTooltipTemplates.lua:172
 GetBackdropColor = <function> defined @SharedXML/SharedTooltipTemplates.lua:191
 backdropInfo = <table> {
 }
 0 = <userdata>
 GetBackdropBorderColor = <function> defined @SharedXML/SharedTooltipTemplates.lua:199
 SetBackdropColor = <function> defined @SharedXML/SharedTooltipTemplates.lua:187
 layoutType = "TooltipDefaultLayout"
 SetBackdropBorderColor = <function> defined @SharedXML/SharedTooltipTemplates.lua:195
}
(*temporary) = <table> {
 bgFile = "Interface\Tooltips\UI-Tooltip-Background"
 tileSize = 16
 edgeFile = "Interface\Tooltips\UI-Tooltip-Border"
 tile = true
 edgeSize = 16
 insets = <table> {
 }
}
(*temporary) = "attempt to call method 'SetBackdrop' (a nil value)"
_G = <table> {
 UpdateOnBarHighlightMarksBySpell = <function> defined =[C]:-1
 ERR_OUT_OF_CHI = "Not enough chi"
 DH_HAVOC_CORE_ABILITY_2 = "Strong melee attack that consumes Fury. If it critical strikes, some Fury is refunded."
 MultiCastActionButton6Cooldown = MultiCastActionButton6Cooldown {
 }
 SettingsSliderOptionsMixin = <table> {
 }
 GetTrainerServiceTypeFilter = <function> defined =[C]:-1
 UNIT_NAMES_COMBATLOG_TOOLTIP = "Color unit names."
 HUD_EDIT_MODE_SETTING_ACTION_BAR_HIDE_BAR_ART = "Hide Bar Art"
 LE_GAME_ERR_CHAT_RAID_RESTRICTED_TRIAL = 774
 SPELL_FAILED_CUSTOM_ERROR_71 = "This partygoer wants to dance

Add Catalyst Gear

I know it isn't strictly "mythic plus loot" but adding the catalyst items could be a good way to check if one of the transformed items is a bis in game.

@herumph

Each second Version Lua error

Message: Interface/AddOns/MythicPlusLoot/MythicPlusLoot.lua:418: attempt to perform arithmetic on field '?' (a nil value)
Time: Fri Dec 23 06:39:45 2022
Count: 2
Stack: Interface/AddOns/MythicPlusLoot/MythicPlusLoot.lua:418: attempt to perform arithmetic on field '?' (a nil value)
[string "=[C]"]: ?
[string "@Interface/AddOns/MythicPlusLoot/MythicPlusLoot.lua"]:418: in function `createItems'
[string "@Interface/AddOns/MythicPlusLoot/MythicPlusLoot.lua"]:848: in function `initFrames'
[string "@Interface/AddOns/MythicPlusLoot/MythicPlusLoot.lua"]:565: in function `showInterface'
[string "@Interface/AddOns/MythicPlusLoot/MythicPlusLoot.lua"]:104: in function `OnClick'
[string "@Interface/AddOns/BigWigs/Libs/LibDBIcon-1.0/LibDBIcon-1.0.lua"]:144: in function `oclick'
[string "@Interface/AddOns/MBB/MBB.lua"]:435: in function <Interface/AddOns/MBB/MBB.lua:423>

Locals: 

Loot table empty

Hello

I have installed the addon but it seems to be empty, no pieces inside when it loads. I try to disable all other addons but I still have the issue. No table loot appears, categories are here but all empty.

Could you check this ?

Regards

No shields

First of all THANK YOU for making this. One of my favorite add-ons. I believe shields used to be in the off-hand section. On my prot pally, I'm not seeing any shields show up for loot. Haven't checked on any other toons.
Thanks again, great mod!

Only showing 7 dungeons?

It's only showing 7 of the 8 available M+ dungeons for me.. the missing one is "Algeth'ar Academy". Perhaps because of the apostrophe?

update esES.lua

if not(GetLocale() == "esES") then
return
end
local AddonName, MPL = ...;
local L = MPL.L or {}

-- Options
L["Enable Minimap Button"] = "Activar botón del Minimapa"
L["If the Minimap Button is enabled"] = "Botón del Minimap habilitado"

-- Armor type
L["Cloth"] = "Tela"
L["Leather"] = "Cuero"
L["Mail"] = "Malla"
L["Plate"] = "Placas"

-- Armor slot
L["Head"] = "Cabeza"
L["Neck"] = "Cuello"
L["Shoulder"] = "Hombro"
L["Back"] = "Espalda"
L["Chest"] = "Torso"
L["Wrist"] = "Muñecas"
L["Hands"] = "Manos"
L["Waist"] = "Cintura"
L["Legs"] = "Piernas"
L["Feet"] = "Pies"
L["Finger"] = "Dedo"
L["Trinket"] = "Abalorio"
L["One-Hand"] = "Una mano"
L["Off-Hand"] = "Mano izquierda"
L["Two-Hand"] = "Dos manos"
L["Ranged"] = "A distancia"

-- Source list
L["Dungeon Drop"] = "Drop de mazmorra"
L["Weekly Vault"] = "Gran cámara Semanal"

-- Dungeons
L["Plaguefall"] = "Bajapeste"
L["De Other Side"] = "El Otro Lado"
L["Halls of Atonement"] = "Sala de la Expiación"
L["Mists of Tirna Scithe"] = "Nieblas de Tirna Scithe"
L["Sanguine Depths"] = "Cavernas Sanguinas"
L["Spires of Ascension"] = "Agujas de Ascensión"
L["The Necrotic Wake"] = "Estela Necrótica"
L["Theater of Pain"] = "Teatro del Dolor"

-- General
L["Item Slot"] = "Tipo de item"
L["Mythic Level"] = "Nivel de mítica"
L["Source"] = "Source"
L["Armor Type"] = "Tipo de armadura"

-- Mythic Labels
L["M0/Valor 1"] = "M0/Valor 1"
L["M+2/Valor 1"] = "M+2/Valor 1"
L["M+3/Valor 2"] = "M+3/Valor 2"
L["M+4/Valor 3"] = "M+4/Valor 3"
L["M+5/Valor 4"] = "M+5/Valor 4"
L["M+6/Valor 5"] = "M+6/Valor 5"
L["M+7/Valor 5"] = "M+7/Valor 5"
L["M+8/Valor 6"] = "M+8/Valor 6"
L["M+9/Valor 6"] = "M+9/Valor 6"
L["M+10/Valor 7"] = "M+10/Valor 7"
L["M+11/Valor 7"] = "M+11/Valor 7"
L["M+12/Valor 8"] = "M+12/Valor 8"
L["M+13/Valor 8"] = "M+13/Valor 8"
L["M+14/Valor 9"] = "M+14/Valor 9"
L["M+15/Valor 9"] = "M+15/Valor 9"
L["Valor 10"] = "Valor 10"
L["Valor 11"] = "Valor 11"
L["Valor 12"] = "Valor 12"
L["Great Vault M+12/13"] = "La gran cámara M+12/13"
L["Great Vault M+14"] = "La gran cámara M+14"
L["Great Vault M+15"] = "La gran cámara M+15"

Incompatability with Handynotes: Dragonflight

Issue #31 is still existing. However not when only your addon is enabled. I narrowed it down to Handynotes: Dragonflight in my case which also uses LibUIDropDownMenu but a newer version.

The version you are using: -- $Id: LibUIDropDownMenu.lua 57 2020-10-20 13:44:40Z arithmandar $
Handynotes: Dragonflight: -- $Id: LibUIDropDownMenu.lua 117 2022-11-29 15:36:42Z arithmandar $

I am no coder by any means but does it perhaps have something to do with what is mentioned in #29 in regards to generically named public functions in your addon, then your addon maybe pulls functions from wrong lib of another addon due to this?

Missing translation

Hey !

tooltip:AddLine("Click to toggle AddOn Window")
favString:SetText("Right click on item to favorite.")

These phrases should be given the possibility of translation.

Shadowmoon Burial Grounds contains loot from non-Mythic+ tables

Loot table for Shadomoon Burial Grounds contain items from non-Mythic-Plus loot tables, which is a HUGE list.

Example, as a hunter, I can see 8 possible necklaces, They are actually coming from the Normal/Heroic/Mythic loot tables.
Wrong

While in-fact, Mythic Plus has no possible necklaces.
Correct

Compare with equipped

Just noticed.. Don't know if it ever worked but holding Shift when hovering over an item does not show the compare window with current equipped item. Holding shift down prior to moving the cursor over the item shows the compare window.

Bug or intended?

image

image

LUA Error when opening window in Dragonflight prepatch

LUA Error when opening window as below, nothing shows in the window.

2x bad argument #3 to '?' (Usage: local line = self:CreateFontString([name, drawLayer, templateName]))
[string "=[C]"]: in function `CreateFontString'
[string "@Interface/AddOns/MythicPlusLoot/MythicPlusLoot.lua"]:563: in function `createDungeonText'
[string "@Interface/AddOns/MythicPlusLoot/MythicPlusLoot.lua"]:1180: in function `initFrames'
[string "@Interface/AddOns/MythicPlusLoot/MythicPlusLoot.lua"]:83: in function `OnClick'
[string "@Interface/AddOns/Masque/Libs/LibDBIcon-1.0-44/LibDBIcon-1.0.lua"]:144: in function <...e/AddOns/Masque/Libs/LibDBIcon-1.0/LibDBIcon-1.0.lua:142>
[string "=[C]"]: ?

Locals:
(*temporary) = "bad argument #3 to '?' (Usage: local line = self:CreateFontString([name, drawLayer, templateName]))"

Host the addon outside of CurseForge

As CurseForge is locking out everyone except Overwolf's own addon manager (source: https://www.wowhead.com/news/ads-revenue-and-api-wowup-and-overwolf-split-over-addon-development-325912), please host this addon elsewhere than CurseForge (at least co-host it elsewhere). Options include:

  • Hosting a .zip file of the addon here in the GitHub repository (this allows WowUp to pull it down)
  • Hosting it on WowUpHub website
  • Hosting it on wago.io (allows monetization to continue, if that is a concern)
  • Hosting it on TukUI
  • Hosting it on WowInterface

I am personally using WowUp to update addons, and while I very much respect that some addon creators want their work monetized, and believe that they should have the option, I do not support the Overwolf lock-out simply because they want everyone to use their app. If monetization is a priority, I suggest using wago.io as addon hosting, as it allows for monetization of addons, also while using WowUp; which shows they're willing to find solutions, rather than the Overwolf approach of refusing to cooperate.
I don't mind anyone hosting their addons on CurseForge, but please, please, please host it outside of CurseForge as well, for those of us who would like to cut ties with CurseForge, but still use your amazing addon ❤️

Dungeon and Item Ids?

As we move into 10.2 - Where are the dungeon and item IDs stored? Looking and the code it seems straightfoward to update but I daresay it'd be hard to just guess the values...

Missing item

Heal Trinket is missing for the Streets of Wonder Section.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.