Type check all mapping values (not just defaults) about react-refetch HOT 11 CLOSED

type check then, catch, andThen and andCatch as well?

from react-refetch.

Yeah, make sure they are functions (or undefined). Any reason not to?

from react-refetch.

since currently we ignore any values for these 4 that are not functions this would be a breaking change (as in it might break someone's app). But i still think we should do it

from react-refetch.

this would be a breaking change

We're incrementing to 1.0.0, so let's do as part of that

from react-refetch.

also, how do you feel about moving the type check definitions to a separate file, connect.js is getting kind of crowded, and it's not like you need to see the type checks to understand the rest of the code?

from react-refetch.

how do you feel about moving the type check definitions to a separate file

+1. We should probably go through and do some overall housekeeping.

from react-refetch.

btw, something i've been meaning to do is add a pure option like react-redux has (only recompute the mappings when props (or context) actually changed (compared with shallowEqual), also only rerender when same thing is true). Any reason why you didn't bring that over when you forked from react-redux?
(I remembered this now because with the defaults assignment, now we add type checking for each mapping, etc it probably gets kind of expensive when you have lots of mappings...)

from react-refetch.

pure option like react-redux. .. Any reason why you didn't bring that over when you forked

I think I left it out for immediate simplicity with the intention of adding it back, but never did.

from react-refetch.

I've opened a PR for the pure optimisation #94

from react-refetch.

I've made these changes regarding type checking individual mappings, etc. I'll open a PR soon. (edit: #96)

from react-refetch.

Closed by #96

from react-refetch.