Allow PromiseState.all(aFetch, bFetch) in addition to PromiseState.all([aFetch, bFetch]) about react-refetch HOT 5 CLOSED

also, just noticed that the api documentation mentions these two functions taking as an argument an iterable but the current implementations only allow for providing arrays, since they then call Array.prototype methods on it. A simple fix would be to add a line at the begging of each doing
iterable = Array.from(iterable)

from react-refetch.

I'm not completely opposed to it, but wanted these methods to mirror their Promise counterparts. It also provides nice symmetry with array spread syntax:

const [a, b] = PromiseState.all([aFetch, bFetch])

these two functions taking as an argument an iterable but the current implementations only allow for providing arrays

Good catch! That's what I get for copying the Promise API doc :)

from react-refetch.

Broke out the iterable bug in #79.

Going to mark this as "discussion" if other people have thoughts, but at this point, I'm slightly opposed to allowing separate parameters.

from react-refetch.

yes, the parity with Promise.all() is a good point, maybe it's not worth it

from react-refetch.

maybe it's not worth it

Closing this for now. Re-open if there's still a reason to do this.

from react-refetch.