'comparison' doesn't work when used along with then() about react-refetch HOT 12 CLOSED

@eyalw Can you give an example and version number please?

from react-refetch.

Yes, I will on Sunday when I get back to my work computer,
but for now it was something like
{
comparison: ...
then: (res) => {
value: res.data,
}
}

and fetches kept being sent even though comparison value didn't change.
then I removed then() and they stopped.

from react-refetch.

This is the exact code, i commented the lines that caused the bad behavior (refetching without change to url)

(the then() is the issue, the comparison was an attempt to solve the issue, which didnt work eiher)

from react-refetch.

Thanks @eyalw, I'll try to look into this week.

from react-refetch.

@eyalw Happen to have anything to do with the missing commas between your key-values?

from react-refetch.

no.. the code compiled, not a noob :)
I must have removed them after i commented or something...

from react-refetch.

Haven't nailed down exactly what is happening, but I was able to reproduce and there's definitely something weird going on here. Hope to dig in more soon.

from react-refetch.

Oh, I see what it is. The identity request in the then is overwriting the original equality check where the comparison happens. Need to test, but pretty sure that's what's happening.

from react-refetch.

See #64 for a fix

from react-refetch.

Workaround in the meantime: set comparison again inside the object returned by then

from react-refetch.

Thanks :)

from react-refetch.

Released in https://github.com/heroku/react-refetch/releases/tag/v0.7.0-beta.3

from react-refetch.