Custom Request Post-Processing about react-refetch HOT 6 CLOSED

I see now that this is the place where the magic happens:

If you can point me in the right direction, I can try to give this a shot.

from react-refetch.

I would like to suggest something like this:

connect(({ name }) => ({
  barFetch: {
    url: `/foos/${name}.csv`,
    dataType: 'csv' // maybe responseType?
  }
}))

@ryanbrainard,

If approve this I would like to pull request.

from react-refetch.

I'm all for accepting more than just JSON, but I'd kind of like to have it based on the Content-Type header in the response rather than adding a new attribute. That might be wishful thinking since there's always going to be some API that doesn't have the right headers and anyway clients will need to send the Accept header as well.

Another idea is to have customizable response processors. This is kind of possible now with PromiseState.then(), but since it's defaulting to JSON, it's too late once it gets to then().

So, given all this, I'm thinking we should use the response Content-Type if we can, fall through to JSON for backward compatibility, and allow it to be overridden by an attribute. Thoughts?

from react-refetch.

@ryanbrainard 👍 for Content-Type.

Please look at my enhancers idea: #9 (comment)

from react-refetch.

@ryanbrainard my suggestion on #40 (comment) can handle this

from react-refetch.

v1.0.0-beta.0 has the ability to change the buildRequest, fetch, and handle Response implementations, which should open up a lot of possibilities here. These features are probably a little too low level for everyday post-processing; however, I want people to kick the tires on them and see what can possibly be built on top of them. I'm going to close this issue now so that we can re-frame remaining enhancements in this new context by opening new issues.

from react-refetch.