henryboisdequin / finnhub-rs Goto Github PK

In the README.md and top of src/lib.rs is where the documentation lies. It would be better if we had a description of what Finnhub actually is, the versioning, and the current place of this API (unstable).

Fix docs regarding how to use Finnhub API with the changes implemented by #1

Now, to create a Finnhub client we use Client::v1 instead of Client::new

Currently, we output and print the value of our API request in our tests. We need to check manually if everything looks fine. If anyone has any ideas where we could assert!, assert_eq!, or use an external crate to see if the values are what we expect.

Some routes such as Press Releases are premium and require the user to pay for a subscription. It would be great if we can support these (same method as all the other ones, no need to worry about auth or something like that). The only issue would be testing as I don't have a premium Finnhub account.

Fix commented out Client methods (errors happen because the response object is not what we defined in our struct (types.rs))

Also, the features of Finnhub which haven't been implemented yet are in todo.md which can be added as well.