hellocomet / hello-cls Goto Github PK

In the "How to use" section of the README.md file, it provides the following example code:

const { namespace } = require('hello-cls')

const context = namespace.initContext()

// I can set a value to a given key on the namespace
namespace.set('beer', 🍺)

// I can get a value from the namespace
console.log(namespace.get('beer'))
// -> 🍺

context.close()

// I can't get a value from the namespace if the context is closed
console.log(namespace.get('beer'))
// -> null

However, with the latest version of the code (1.0.4), calling namespace.get('beer') after calling context.close() actually returns '🍺' instead of null.

I believe the root cause is the combination of two things that the code is doing:

1. Calling context.close() removes the associated async ids from the namespace map, but it does not clean out the internal store map, so these values are still retrievable by any code that still has a handle on the context
2. Calling context.close() does not set the _currentContext in the namespace object to null if this context is the object that _currentContext is currently pointing to. Failing to do this allows access to the closed context object via the namespace object within the same async process.

The combination of the above two conditions is causing the example to fail. Changing either ought to make the example code true again. It may be desirable to change both though.