helgastogova / react-stateful-bottom-sheet Goto Github PK

Hello!
First of all, very nice library, thanks for sharing.

I'm trying to also include a button on the drawer which will open the drawer which will have search filters on it. Doing a setOpen(true) doesn't seem to work, unfortunately (while setOpen(false) does).

<BottomSheet>
  {({ isOpen, setOpen }) => (
	  <div>
		  <FilterTagGroup onChange={onChangeSelect} urlSearchParams={urlSearchParams} />
		  <ButtonSecondary
			  variant={'on-light'}
			  onClick={() => setOpen(!isOpen)}>
			  {isOpen ? 'Close Filters' : 'Open Filters'}
		  </ButtonSecondary>
	  </div>
  )}
</BottomSheet>

Am I doing something wrong?

Thanks

ESLint and my IDE are unhappy about the any, any typing on isOpen, setOpen props. It would be great if the type was exported so it could be made explicit:

{({ isOpen, setOpen }: BottomSheetChildProps) => (

Hello again!

When updating from 1.0.7 to 1.0.8, I now get a "index.js:481 React Router caught the following error during render TypeError: Cannot read properties of null (reading 'useRef')" which is referring to the useRef in index.tsx line 36.

Rolling back to 1.0.7 makes this error go away, I've been trying to troubleshoot, but am not experienced enough in React/TypeScript to spot the issue.

Also 'fullHeight' is missing from the useEffect deps on line 43.

Cheers

Hello again,

If you pull up enough on the Bottom Sheet while it is closed, it then reveals the text underneath. This screenshot shows what I mean:

I'm not too bothered by it, but might be nice to fix it. I guess make the panel longer somehow?

Totally no rush in this, but it would be nice to be able to specify your own transition in the motion.div, easeInOut for example.

Additionally, dragging currently uses the transition, but opening and closing by setOpen does not.