heiiow2 / music-downloader Goto Github PK

q to quit, ok to download, .. for previous options, . for current options, int for this element: 13
artists: 1; releases 1; tracks 10
0) artist: 'Lorna Shore' from US, 'American deathcore band'

1. release: 'Immortal'
2. track: 'Darkest Spawn'
3. track: 'Death Portrait'
4. track: 'Hollow Sentence'
5. track: 'Immortal'
6. track: 'King Ov Deception'
7. track: 'Misery System'
8. track: 'Obsession'
9. track: 'Relentless Torment'
10. track: 'This Is Hell'
11. track: 'Warpath of Disease'

q to quit, ok to download, .. for previous options, . for current options, int for this element: ok
INFO:root:Starting Downloading of metadata
INFO:root:Fetching Download Links
[download] Downloading playlist: GBDHC2012001
[youtube:search] query "GBDHC2012001": Downloading page 1
[youtube:search] query "GBDHC2012001": Downloading page 2
[youtube:search] playlist GBDHC2012001: Downloading 0 videos
[download] Finished downloading playlist: GBDHC2012001
Traceback (most recent call last):
File "/home/lars/Projekts/big projects/music-downloader/src/main.py", line 104, in
cli(start_at=0)
File "/home/lars/Projekts/big projects/music-downloader/src/main.py", line 92, in cli
download_links.Download(file=STEP_TWO_CACHE, metadata_csv=STEP_ONE_CACHE, temp=TEMP, session=session)
File "/media/lars/Volume/Projekts/big projects/music-downloader/src/download_links.py", line 29, in init
youtube_url = youtube_music.get_youtube_url(row)
File "/media/lars/Volume/Projekts/big projects/music-downloader/src/youtube_music.py", line 31, in get_youtube_url
result = get_youtube_from_isrc(row['isrc'])
File "/media/lars/Volume/Projekts/big projects/music-downloader/src/youtube_music.py", line 17, in get_youtube_from_isrc
video = ydl.extract_info(f"ytsearch:{isrc}", download=False)['entries'][0]
IndexError: list index out of range

Hi,

On non-english systems, the program immediately crashes as it can't find the hardcoded "~/Music" directory.

FileNotFoundError: [Errno 2] No such file or directory: '/home/xxx/Music'

Patch proposal: #6

im using WSL2 on Win11.
maybe im doing something wrong :(

just a quick note to myself

https://y.com.sb/api/v1/search?q=Zombiez+-+Topic&page=1&date=none&type=channel&duration=none&sort=relevance

https://y.com.sb/api/v1/channels/playlists/UCV0Ntl3lVR7xDXKoCU6uUXA

https://y.com.sb/api/v1/playlists/OLAK5uy_kcUBiDv5ATbl-R20OjNaZ5G28XFanQOmM

It cant determine the Music Directory '/Music'. but finds it after '\Music'.

May be create directory separately after CDing to %home%.

It should be, https://musicbrainz.org/, otherwise

yt-dlp doesn't seem to have the same download speed restrictions that youtube-dl does.

It might even be a drop in replacement?

Hello!
After installing the program using pip, I get the following error when running it.
Traceback (most recent call last): File "/Library/Frameworks/Python.framework/Versions/3.9/bin/music-kraken", line 5, in <module> from music_kraken import cli File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/music_kraken/__init__.py", line 15, in <module> from .lyrics import lyrics File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/music_kraken/lyrics/lyrics.py", line 5, in <module> from . import genius File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/music_kraken/lyrics/genius.py", line 25, in <module> class Song: File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/music_kraken/lyrics/genius.py", line 66, in Song def fetch_lyrics(self) -> str | None: TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'
I'm on MacOS Big Sur, Python 3.9.4
Would someone mind checking this out?

I think that the current approach of only using ISRC for YouTube searches is a bit problematic. While it's correct that YouTube finds it out quickly via ISRC, not all songs there have ISRCs (as YouTube cares less about music than, say, Spotify), and sometimes the music just appears on the top through a search of its name. I am also not sure about how music-kraken handles music in different languages - musicbrainz tends to list their transcription - and rather lists its original name as an alias
It would be nice if the scraper searches for the name if both ISRC and Musify fails.