Git Product home page Git Product logo

ioscontextualmenu's People

Contributors

bryant1410 avatar hectormatos2011 avatar hsin919 avatar jalmaas avatar jalmaas-agens avatar mxcl avatar redent avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

ioscontextualmenu's Issues

Methods get called but no menu when launching app from shortcut

Hi, im having trouble using this framework when launching from a URL scheme. All the necessary methods get called to setup my array, the delegate methods for returning the label and image all gets called but the menu itself never appears when launching from a URL

Suggestion for improvement / Use with collectionViews cells

I'm using it for collection views cells and it seems that didSelectItemAt of the collection view is not called because the menu gesture recognizers overrides the touches.
So to get the cell indexPath where the menu is shown I have modified:

//ContextualMenu+Extension

-    @objc(contextualMenu:didSelectItemAtIndex:)
-    optional func contextualMenu(_ menu: ContextualMenu, didSelectItemAt index: Int)
+    @objc(contextualMenu:didSelectItemAtIndex:sourceAtPoint:)
+    optional func contextualMenu(_ menu: ContextualMenu, didSelectItemAt index: Int, sourceAt point: CGPoint)

and

//ContextualMenu / didSelect(menuItemView: ContextualMenuItemView)

//      delegate?.contextualMenu?(self, didSelectItemAt: menuItem.index)
        delegate?.contextualMenu?(self, didSelectItemAt: menuItem.index, sourceAt: startingLocation)

Using it this way

func contextualMenu(_ menu: ContextualMenu, didSelectItemAt index: Int, sourceAt point: CGPoint) {
let point2 = UIApplication.shared.keyWindow?.convert(point, to: collectionView)
let indexPath = collectionView.indexPathForItem(at: point2)
let cell = collectionView.cellForItem(at: indexPath)
}

Is it acceptable or is there a better way to use it with collectionViews?

Custom titleViews always overridden

In layoutMenuItemsIfNeeded the titleView is set to a custom view if the delegate responds to the custom view method. Right after that though, there is an if-condition that overrides the titleView in any case, either with the regular case or with an invisible Item (line 719), or am I wrong here.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.