hearthsim / sunwell Goto Github PK

Chrome: Version 50.0.2661.86 (64-bit) Mac OS 10.11.2

I'm not sure how Hearthstone does it. @andburn do you know?

eg. due to missing assets. cc @beheh

Has to be included

I haven't actually tested it because http://hearthstonelabs.com/cards#lang=enUS is down but TB_SPT_Minion2 has a non-square texture (1024x2048)

Also see HearthSim/Joust#122

Would be really nice.

The elite dragon is not the same thing as the legendary rarity even though most legendaries have both set.

Hearthstone (and hearthstonejson) are using NAXX for the short of Naxxramas but Sunwell use NAX.
https://github.com/HearthSim/sunwell/blob/master/sunwell.js#L1247

Hello! Thank you for a wonderful script!
Very cool thing, though - thank you!

1. This version of the script is not working (24 Dec 2016)
2. Russian fonts look horrible on http://hearthstonelabs.com/sunwell. (Maybe use BenguiatBoldITC and FranklinGothicURWConMed?)
3. How can I render a large number of cards on one page? (Do not write the text by hand?)

Example: https://www.youtube.com/watch?v=0IhK1Xkj9VU&t=4m33s

Card descriptions with manual linebreak (starting with [x]) tend to overflow the body.

We should be rendering them and then check whether they exceed the body. If they do, either resize the sprite or just rerender with a slightly smaller font size until they are contained.

The color palette of the imp master isn't correct.

http://hearthstonelabs.com/cards#lang=deDE;cost=10;set=OG;detail=OG_133

Reference screenshot in-game:

The body text seems to reflect at the top, and sometimes at the bottom. Are we exceeding bounds or something?

Notice the top of the K, f and the t in the first line.

I don't know how we'll do this, or where we'll do this, but for completion sake:

AT_128 @ zhCN

Do you think there is way to get realtime highlighting when rendering the cards?

I have something like that in mind (ie for query 'ta')

http://opentype.js.org/

Instead of the kludge we have right now, a more performant way would be using opentype. This would only be viable on node though.

I removed sunwell.min.js from the repo so I'll be moving it to build automatically off our build server.

Spirit of Lucentbark (token left behind when Lucentbark dies) is showing the wrong text.

The following link is included in the readme, but only leads to a 404 page https://sunwell.hearthsim.net/branches/master/sunwell.js

I can't find any references to Sunwell on the hearthsim website, so I'm not sure if the url is incorrect or if the issue lies elsewhere.

They've been outdated since the layer rework.

Cards: Lesser Onyx Spellstone, Lesser Sapphire Spellstone, Lesser Emerald Spellstone.

We'd like to directly be able to set the mana/attack/health colors (negative/positive/neutral = red/green/white) without having to rely on the internal (stateful) mechanism. The main motivation is using this in Joust, where the colors can be deduced by the default card values and other tags, such as health/max_health.

As an example, it's currently not easy to set the health on a minion effected by equality - it's health might be lower than it's default health, but it should be white since the current health is equal to the max health. Compare this to a minion though that has been noramlly attacked, and has it's current health set to one - it should be red.

@jleclanche commented on Mon Mar 12 2018

@beheh commented on Tue Mar 13 2018

Any downstream user would need to switch based on browser support.

@jleclanche commented on Sun May 20 2018

Could try using https://github.com/Intervox/node-webp

The current method is using the ID, which is no good for custom cards.

https://github.com/palantir/typesettable

Can probably do typesetting much more reliably using that.

The medivh brawl implemented HIDE_STATS which does the following:

• Hides health and attack from the minion token on the board
• Hides health and attack from the card render
• Does not render text for the mana gem.

Sunwell should have a way to do the latter two.

This is a story for changing the font and size we are using for our Korean translations on the cards and the Twitch Extension. We have a customer support ticket opened here of a new user giving feedback on how hard it is to read the font:

https://app.intercom.io/a/apps/lhrr2hfa/inbox/inbox/all/conversations/17911380051

Also here is a screenshot of what a card looks like on the site in Korean right now:

https://s3.amazonaws.com/art.hearthstonejson.com/v1/render/latest/koKR/512x/AT_001.png

This is what shifting mode looks like:

The area used to clip normal minion card images will sometimes persist into spell cards, causing the grey area above. Happens in both chrome and safari on osx.

There's some visible cut happening there. The asset itself looks kinda weird, should probably just get the one from ingame.

The following is a reference in-game card image:

The following is the card image taken from hearthstonelabs.com:
http://hearthstonelabs.com/cards#lang=zhTW;cost=3;page=2;detail=EX1_083

Most words in the description are missing.
The same problem exists in almost all other cards that has multi-line description.

With support for arbitrary cards nearly complete, we're still missing a better looking default texture.

I figure we might as well add this in Sunwell itself, but we'd need the texture to be the same license as Sunwell (or even more permissive).
Anyone wants to take a crack at it? @andburn feeling inspired? :)