Git Product home page Git Product logo

devise-uncommon_password's Introduction

Hi there, I'm Chris Larsen ๐Ÿ‘‹

Languages and Frameworks:

Crystal VueJS Ruby on Rails

  • ๐Ÿ”ญ Iโ€™m currently working on Chronos
  • ๐Ÿ’ฌ Ask me about VueJS
  • ๐Ÿ“ซ How to reach me: My LinkedIn Profile
  • โšก Fun fact: I love to program while outdoors.

devise-uncommon_password's People

Contributors

andyklimczak avatar dependabot[bot] avatar ethagnawl avatar hclarsen avatar jcody avatar jdmurphy avatar jystewart avatar madejejej avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

devise-uncommon_password's Issues

Still maintained? + Localization support

Is this gem still maintained?

If so, it would be great if you can allow localization of the error message.

This block

def not_common_password
if Devise::Models::UncommonPassword.common_passwords.include? password.downcase
errors.add(:password, "is a very common password. Please choose something harder to guess.")
end
end

Should probably just have something like:

errors.add(:password, :common)

Which will just allow us to define the message in a localization file:

# config/locales/activerecord.en.yml
en:
  activerecord: 
    errors:
      models:
        user:
          attributes:
            password:
              common: "must not be a commonly used password"

Devise 4.8 support?

I'm looking to potentially use this gem, but according to the gemspec and rubygems, Devise 4.8 isn't supported, so I'd have to downgrade.

Is it possible to add support for this? I'm not sure if this is trivial or difficult, but this version has been out for about 6 months now.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.