haywardmorihara / gh-tidy Goto Github PK

ALL branches? Or only ones w/ recent activity?

What to do in the case where conflicts need to be resolved? Do it there on the spot?

Merge as an alternate option? I know a good number (if not a majority of developers) prefer merging to rebasing...

Make it configurable? Where is the best place to put that configuration?

If there are uncommitted changes, warn. Could:

• Auto-fail
• Auto-continue
• Wait for user action (Y/N)

Ideally, configurable

Hi! In my case, I have some PRs from main -> dev branches for keeping those up to date.
Is it possible to wrap the entire contents below in a condition like (branch != trunk_branch)

So that users don't have to install it

It seems to be telling me there are updates when there aren't...

ONLY non-drafts

Do they require my response on a comment?

Is CI failing?

I'm surprised this isn't more of a documented issue? The official docs about developing extensions recommends using bash...

I'd want to see if there's an established best practice around this.

At the least, would be nice to document that this uses bash and doesn't work with Windows

Token storage change in latest release of gh

This is a message from the GitHub CLI team, maintainers of gh, writing to inform you that the most recent release of gh contains changes which may affect your extension. The latest release introduces the feature of storing authentication tokens in the system keyring (encrypted storage) instead of in a plain text file.
The keyrings that are supported are:

• Keychain on macOS

• GNOME Keyring on Linux (Secret Service dbus interface)

• Wincred on Windows

This has huge security benefits for the users of our tool and was one of our oldest outstanding issues. Unfortunately this change has the potential to break extensions that rely on utilizing the users authentication token to work.

In order to have continued compatibility with gh there are some actions you, as an extension author, need to take. These actions will depend on the implementation of your extension.

Extensions built in Go using go-gh:

1. Upgrade your go-gh version to v1.2.1, the latest version.

   • This can be done using go get github.com/cli/[email protected]

2. Verify that in your extension retrieval of the user authentication token is done using the auth.TokenForHost function.

   • If you were previously accessing the authentication token using any other method it will no longer work.
   • Automatic resolution of the authentication token when using the API clients will continue to work without changes.

All other extensions:

1. Verify that in your extension retrieval of the user authentication token is done by shelling out to the gh auth token command.

   • If you were previously accessing the authentication token using the gh config get command, reading the configuration file directly, or any other methods it will no longer work.

As of right now storing the authentication token in the system keyring is an opt-in feature, but in the near future it will be required and at that point if the changes above are not made then your extension will be broken for all users. If you have any questions/concerns about this change please feel free to open a discussion in the gh repo.

Thanks,
The GitHub CLI Team

Make it so users can opt-out of a tidy step, because not everyone will want the same things

Bonus points if we can make it so developers can write there own and have the tidy script call it

Is it possible to record metrics about usage in a non-invasive manner?

Show status and details of PRs that I need to review

Are they new? Is there a new response since the last time I looked?

See #41 for the genesis of the idea

Make it so users can opt-out of a tidy step, because not everyone will want the same things

Different developers use branches in different ways - it would be nice if they configure gh tidy so that they could specify (in a local file) what branches should be considered for deletion, rebase, or any other tidy actions

Pretty likely that someone's used some unexpected characters in branch names.

I'm getting an error attempting to tidy a repo:

Pruning local branches that show as 'merged' to local ...
fatal: malformed object name --format=%(refname:short)

If there is some way to get more info -- like what the branch name is that's causing trouble -- that would be super-helpful. There's no more information, and tidy continues on (yay!).

Something like https://github.com/thombashi/gh-upgrade/blob/main/.github/workflows/tests.yaml?