haxxnz / vaxxnz Goto Github PK

Looking for appointments renders appointments today (which is good) but shows times that have passed (eg. Pharmacy in Rosedale, Auckland showing appointments for this morning)

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to website
2. Click on the language selector
3. Observe mismatched font styles

Screenshots

should look more like this

Describe the bug
Loading state layout is not properly aligned

To Reproduce
Steps to reproduce the behavior:

1. Switch between radius
2. observe loading state
3. styling is not right

Screenshots

create-react-app ships with ESLint and it seems it is not being used. There's no "lint" script in the package.json, yet there is an eslintConfig.

Re-implement linting as it seems the project is setting up code best practices. See #77

There's currently an outstanding PR for GH action for prettier. Tracking the progress here as well.

Is your feature request related to a problem? Please describe.
I'm always frustrated when it's confusing and error prone to deal with lat/lng/placeName in our code. Initial implementation was shipped on a tight timeline, it was improved a bit now, but we can make it even better.

Describe the solution you'd like
Only have lat/lng/placeName state in URL. If you want to change those parameters, you HAVE to push to History API.

Additional context
Shareable URL links is a crucial feature for us, we've seen a lot of growth through clever use of suburb links in subreddit communities. Making this feature robust is important to set up our platform for growth.

Describe the bug
When selecting Auckland Region or Wellington Region in location selector, no results are yielded.

To Reproduce
Steps to reproduce the behavior:

1. Go to website
2. Search Auckland Region
3. No results shown

Screenshots

Additional context
I think the best solution here is to hide Regions in AddressFinder completely. They are way too unspecific. Let's only do residential adresses or at most suburbs.

As a user, I want to see a privacy policy
so that I know how my data is being treated and I have peace of mind

This issue covers the creation of a privacy policy, and the addition of a link to it at the footer of the page

To Reproduce
Steps to reproduce the behaviour:

1. Go to 'https://vaxx.nz/'
2. Pick a location, i.e. 'Epsom'
3. Press the back button, it'll leave Epsom showing in the location picker.

Describe the bug
We use a variety of border widths. Looks untidy.

To Reproduce
Steps to reproduce the behavior:

1. Go to website
2. Click into a "Open today" website
3. " Walk-in vaccinations available" border is different from calendar border

Screenshots

Additional context
1 pixel should be good everywhere

Is your feature request related to a problem? Please describe.
We switched Google Autocomplete to AddressFinder.nz autocomplete, but:
We still use Google Reverse Geocoding to fetch suburb name for the "Use my current location" feature.

Describe the solution you'd like
Can we use https://addressfinder.nz/api/nz/address/reverse_geocode/ to replace Google Reverse Geocoding?

Additional context
The documentation says we need both API KEY and API SECRET, does it mean we have to have a backend? We want to stay 100% static to reduce number of moving parts and be web scale.
If we absolutely HAVE TO have a server, we can deploy a Netlify Function? I'd rather not tho

Getting walk-ins

As a user, I'd like to see the location of the vaccination location on a map in the modal (above Get Directions) so that I can easily find the location.

Some ideas

• iFrame map render with Mapbox
• Pained path from current location to destination
• Open to ideas

Describe the bug
"Public Holidays" text for Life Pharmacy St Lukes is cut-off

To Reproduce
Steps to reproduce the behavior:

1. Go to website
2. Find Life Pharmacy St Lukes in Open Today
3. Observe Public Holidays

Screenshots

Additional context
Props to @geeksteph for spotting this.
Might be a data issue...

Is your feature request related to a problem? Please describe.
Please internationalise the Healthpoint instructions in HealthpointData.ts by adding them to the i18n translations file.

export enum Instruction {
  anyoneEligible = "Anyone currently eligible can access",
  makeAppointment = "Make an appointment",
  enrolledOnly = "Eligible GP enrolled patients only",
  walkIn = "Walk in",
  invitationOnly = "By invitation only",
  driveThrough = "Drive through",
  allowsBookings = "Allows bookings",
}

Describe the bug
Currently the language picker says 'Language' by default. For someone who doesn't know English, they mightn't know what language means and to click there to change it. I would assume though that they recognise 'English' as a place to change the language.

This stays as English once set in local storage though.

Describe the bug
Warning: validateDOMNesting(...): <h3> cannot appear as a descendant of <p>. when openning a day

To Reproduce
Steps to reproduce the behavior:

1. run on local
2. open day
3. see it in console in devtools

Additional context
it's just a react warning, needs fixing pretty annoying

Is your feature request related to a problem? Please describe.
It's good practice to supply a cookie notice on the website as we have implemented GA and potentially other cookies.

Describe the solution you'd like

1. Design an unobtrusive cookie notification that looks better and more on-brand than the default react-cookie-consent library banner.
2. Implement a cookie notice library that supports the design.
3. Memorise consent for 6 months (usually a built-in option with cookie consent libraries, or manually store in localStorage)

Additional resources
https://www.npmjs.com/package/react-cookie-consent

Describe the bug
Doctor image is a bit off from the container on some languages.

To Reproduce
Steps to reproduce the behavior:

1. Go to main site.
2. Select Espanol
3. See doctor image. It's different from English language.

Screenshots

Additional context
We should fix it in a way which works for any header height.

Hey team!

Loving the work so far! This is inspiring to me as a junior dev. Would love to help out where I can :)

Just a minor fix to link in the first paragraph of the README

The link currently takes you to here:

When using the app, I was excited to see days that had a lot of available time slots, only to be disappointed when drilling down onto that day and discovering that the slots are only for 1 vaccination centre that is in an inconvenient location.

I propose adding another line of text under each calendar entry that indicates how many locations there are as well.

Describe the bug
Language select label doesn't change when selecting another language

To Reproduce
Steps to reproduce the behavior:

1. Go to vaxx.nz
2. Click on English
3. Select some other language
4. The language label doesn't change

Additional context
Something is up with the way we're using Select component from base web

walk-ins and drive-throughs, enrolled GP only, etc etc

Is your feature request related to a problem? Please describe.
It would be amazing for someone to internationalise the opening hours using the currently selected locale and date-fns library. We already do this in the calendar, but not in the opening hours.

Mon – Tue 9:00 AM – 6:00 PM
Wed 9:00 AM – 7:30 PM
Thu – Fri 9:00 AM – 6:00 PM
Sat 9:00 AM – 7:30 PM
Sun 10:00 AM – 5:00 PM

When you open the booking modal by clicking a date on the calendar, let users sort by:

• distance
• number of slots available

As a covid vaccine site operator who isnt listed on BookMyvaccine
I want to submit details about my vaccine site in a form
So the Vaxx team can receive my site information for review so they can put it on the website

Create a submission form for vaccine sites that aren't listed on BookMyVaccine

Village Health - Christchurch on Lincoln road is missing from the site

As a vaxx user
I want to see ways to get vaxxed at Bargain Chemists
So that I can get vaccinated, and be less affected by COVID

This covers scraping the bargain chemists, and storing the results somewhere https://www.bargainchemist.co.nz/pages/covid-19-vaccination

Implementing the following:

• improving update speed
• publishing data in a cleaner format for other people to use

Is your feature request related to a problem? Please describe.
The error message is a bit cluttered among other content. It needs room to breath. Maybe add an icon or an SVG image too to make it fun too?

Describe the solution you'd like
Design a better error state which looks better than what we have now.

Additional context

Describe the bug
Some language names are a bit too long and are wrapped over to the new line. We shouldn't word wrap in that dropdwon.

To Reproduce
Steps to reproduce the behavior:

1. Go to website
2. Click on language selector

Screenshots

Additional context
Add any other context about the problem here.

Quick one, which may be user issue on my part but Glen Innes vaccination centre seems to be missing here?
It's right next to Mt Wellington centre so figured they'd be together. (edited) @oeed

To be investigated

Is your feature request related to a problem? Please describe.
E.g. I'm always frustrated when my family member sends me a website link, but it's not in my native language.

Describe the solution you'd like
Shareable link to your language. Either ?lang=lang or maybe /lang? Not sure

The header on your page says "See every available vaccination booking slot near you."

But I'm not sure it's showing the booking slots that are available that are outside the official booking system? There's quite a few at bargain chemist in CHCH https://www.bargainchemist.co.nz/pages/covid-19-vaccination as well as Unichem in CHCH https://unichemcashelpharmacy.gettimely.com/ From what I could see your system doesn't check those?

It might be worth changing the wording to note there are other options (maybe just if someone puts in a CHCH address)?

Page wont load if no location is set

To Reproduce
Steps to reproduce the behavior:

1. Go to 'vaxx.nz
2. dont set a location
3. wait for listings to load

Describe the bug
Clicking radius filter on mobile brings up keyboard. It shouldn't, there's no text to input.

To Reproduce
Steps to reproduce the behavior:

1. Open vaxx.nz on mobile
2. Click "within 10km"
3. You'll see keyboard pop up
4. It shouldn't

Screenshots

Device:

• iPhone 7 plus
• Safari

Additional context
Base web Select component can take input, but for our use case we should disable that and make it dropdown only. Maybe there's a prop for that?

While the data is public isn't not at all obvious at the moment how to actually use the data. It'd be good to create a doc that illustrates how the data is structured and what's needed to use it.

Describe the bug
Setting location by a city doesn't retrieve the city name

To Reproduce
Steps to reproduce the behavior:

1. Go to 'vaxx.nz'
2. Click on set your location to any city/region e.g. Rotorua
3. placeName gets set to either lat or lng in both URL and location picker

Screenshots

Device:

• Device: MacBook Pro
• Browser: Firefox

Additional context
This is probably due to us setting placeName params by suburb.

Describe the bug
website displays wrong time

To Reproduce
Steps to reproduce the behavior:

1. Go to 'vaxx.nz'
2. look at some of the walk-in locations
3. compare the time

Screenshots

Is your feature request related to a problem? Please describe.
E.g. I'm always frustrated when my language selection doesn't save.

Describe the solution you'd like
persisting the language selection to localStorage

Describe the bug
Our site is getting a bit laggy. We do a lot of data processing in render method - we should memoize it as much as possible.

To Reproduce
Steps to reproduce the behavior:

1. Go to website
2. Open React Profiler
3. Start profiling
4. Open a modal
5. Observe long-running renders

Screenshots

Additional context
We need to useMemo a bunch of variables. especially when we do .sort, .filter and .reduce.

The offical guidance from the Ministry Of Health is that you shouldn't be travelling too far out of your local area to get a vaccine.

We should show a message letting users know that its not recommended to travel outside of their local area to get a vaccine when they are filtering by any radius larger than 10km.

For the BaseWeb modal component we've currently done the styling in JS. This ugly bit of styling code is copy pasted to all the Modals on the site.

It would be nice if we could abstract this styling code and the modal out into a common modal component.

https://github.com/CovidEngine/vaxxnz/blob/04aee7c42eafa2dcd3f91d94deb170e9ef8fe8d7/src/walk-in/modal/WalkInModal.tsx#L49

Implement i18n in React, outsource translations to the community

Currently the data for other locations is baked in to the JS, it'd be better to fetch it separately like we do with other data.

Hello,

An example where link to map is broken:

Epsom Vaccination Centre
382 Manukau Road Epsom, Auckland 1344. Parking at Alexandra Park, entry from 30 Campbell Crescent. (4km away)

And the link for walking direction:
https://www.google.com/maps?t=r&daddr=382+Manukau+Road+Epsom,+Auckland+1344.+Parking+at+Alexandra+Park,+entry+from+30+Campbell+Crescent.&dirflg=w

The link shouldn't include the Parking info. Have included screenshot of maps unable to find it.

Maps would work if the link was:
https://www.google.com/maps?t=r&daddr=382+Manukau+Road+Epsom,+Auckland+1344

Thanks,
William.