harmowatch / ngx-redux-core Goto Github PK

First of all, great take on redux with angular!

I have some naming suggestions from browsing the repo:

• interface ReduxModuleChildConfig is located inside file redux-child-module-config.interface.ts . "child" and "module" are switched. This is a little confusing. I don't know which variant you want but I suggest to name the file the same as the interface.
• same for interface ReduxModuleRootConfig / redux-root-module-config.interface.ts
• ReduxActionWithPayload is inside file redux-action.interface.ts -> same issue as the other two. In this case I suggest to name the interface ReduxAction, it's more concise.

Hey,

in case you're not intending to develop this repo any longer please consider adding a statement on the README that you would look for another maintainer...

Or archive the repo (and reflect that on npmjs.com).

I at least want to go over my repos this year as well.
The last PRs came from bot and issues weren't created for a year. That's why I'm asking.

I'm submitting a ... (check one with "x")

[ ] bug report => check the FAQ and search github for a similar issue or PR before submitting
[ ] support request => check the FAQ and search github for a similar issue before submitting
[x] feature request

Current behavior
It will not run into an error but it's an unexpected behavior to register a state twice.

Expected/desired behavior
It shall throw an exception to warn the developer and to avoid potential side effects.

Love the concept, but it needs to work with lazy loaded modules & have an OTB storage persistence option (that works with lazy loaded modules). Any plans?

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop renovations until it is fixed.

Configuration file: package.json
Error type: Cannot parse package.json
Message: This package.json contains invalid JSON and cannot be parsed. Please fix it, or add it to your "ignorePaths" array in your renovate config so that Renovate can continue.

I'm submitting a ...

[x] feature request

That's a really awesome project!!!
The one thing I'm missing is a native support for Anguar-routing. It would be great if your library could be configurated to manage the routes in the redux app state.